Terminator

Changing layout causes scrollbar settings to be lost

Bug #172829 reported by Chris Jones
2
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
High
Chris Jones
Terminator 1.0 "Patrick"

Bug Description

When I open a new terminal, existing ones with no scrollbar get their scrollbar back.

Chris Jones (cmsj)
Changed in terminator:
assignee: nobody → cmsj
importance: Undecided → High
milestone: none → 1.0-beta
status: New → Triaged
Revision history for this message
Chris Jones (cmsj) wrote :

This is because of line 456:

    parent.show_all ()

when reparenting widgets. We hide the scrollbars rather than taking them away. Either stop using show_all() or run through the terminals after show_all and re-hide hidden scrollbars.

Revision history for this message
Chris Jones (cmsj) wrote : Re: [Bug 172829] Re: Changing layout causes scrollbar settings to be lost

Status: Fix Committed

Chris Jones wrote:
> away. Either stop using show_all() or run through the terminals after
> show_all and re-hide hidden scrollbars.

I've opted for the former because it seems more correct. Newly created
widgets are specifically shown after being added to the window, and
after destroying widgets there doesn't seem to be a need to re-show them.
I hope this is correct Gtk usage, but it works for me and fixes this bug.

--
Chris Jones
  <email address hidden>
   www.canonical.com

Chris Jones (cmsj)
Changed in terminator:
status: Triaged → Fix Committed
Revision history for this message
Chris Jones (cmsj) wrote :

Fixed in 0.7

Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.