Web Client: entering user surveys UI causes proliferation of pcrud drones

[Chris Sharp]

In the 3.0.0 web client, entering Other -> Surveys within a patron account causes a permission check on every response to any survey the user has answered. This appears to be because of the way the fix for bug 1511358 was developed, which uses a pcrud call to flesh the values of all surveys, survey questions, and survey responses associated with the user. See the IRC discussion at http://irc.evergreen-ils.org/evergreen/2017-10-27#i_332043 and following.

This presents an issue that blocks go-live for PINES on the web client.

Evergreen 3.0.0
OpenSRF 3.0.0
PostgreSQL 9.5
Ubuntu 16.04 LTS

[Chris Sharp (chrissharp123)]

After some further investigation, I can confirm that the current survey code fleshes the responses of any patron who has answered each survey answered by the current user. I'm not sure what the correct solution is though, and I would appreciate eyes from more experienced Angular/JS developers about what should be done.

[Bill Erickson (berick)]

As discussed in IRC, the fleshing is too aggressive here. Putting together a cleanup patch.

[Bill Erickson (berick)]

Fixes pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1728122-survey-response-flesh-repair

From commit:

Avoid collecting survey/question/answer data via deep pcrud fleshing. Opt instead to organize the data locally using the values fleshed directly on the response object.

Additional fixes included:

1. Avoid displaying survey responses for out-of-scope surveys.
2. Format survey response dates using the configured date format instead of displaying a bare ISO date.

[Bill Erickson (berick)]

Minor tidiness fix coming in about 5 minutes...

[Bill Erickson (berick)]

Fix force-pushed. Good to go.

[Chris Sharp (chrissharp123)]

Tested on PINES data - working as expected and all the craziness has disappeared.

Thanks, Bill!

Signoff branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1728122-survey-response-flesh-repair

[Galen Charlton (gmc)]

Pushed to master, rel_3_0, and rel_2_12. Thanks, Bill and Chris!