Convert check, suspend and resume to convergence

Bug #1727142 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Triaged
Medium
Unassigned

Bug Description

These operations still rely on a Stack-level lock. But since convergence doesn't use Stack-level locks there's no guarantee that they couldn't be happening simultaneously with a stack update. That'd probably be bad.

Also, it'd be really useful if these operations followed the same rules as updates from the user perspective - i.e. you could safely start an update in the middle of a check operation or whatever.

Zane Bitter (zaneb)
Changed in heat:
milestone: none → next
Revision history for this message
Zane Bitter (zaneb) wrote :

Also stack abandon, if we still care about that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/514476
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1d24d47e7e4b6295fa12b6ec59efa0db5b2d79c7
Submitter: Zuul
Branch: master

commit 1d24d47e7e4b6295fa12b6ec59efa0db5b2d79c7
Author: Zane Bitter <email address hidden>
Date: Tue Oct 24 13:34:36 2017 -0400

    Don't try resource-level locks when stack locked

    The actions SUSPEND, RESUME, SNAPSHOT, CHECK, and also DELETE when
    abandoning rather than deleting a stack, have not (yet) been converted
    to the convergence workflow and still do a legacy-style in-memory
    traversal with the Stack lock held, even on stacks with convergence
    enabled. Since a7376f7494b310e9367ebe5dcb43b432a4053023 we have been
    attempting to get a lock on the Resource to do these operations, even
    though there is no engine ID set (which caused a WARNING-level log). For
    these operations, respect existing Resource locks when convergence is
    enabled, but don't try to acquire the lock.

    Change-Id: I6f232380398a7caf9664717debfe39e3422e70d8
    Related-Bug: #1727142
    Related-Bug: #1662585

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.