OpenStack + Chef

[all] platform_family breaks chef 13.x

Bug #1724987 reported by Arun S A G
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Critical
Seb-Solon

Bug Description

platform_family is not recognized by ohai in chef 13.x. Please use node['platform_family']

OpenStack Infra (hudson-openstack)
Changed in openstack-chef:
assignee: nobody → Arun S A G (sagarun)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-identity (master)

Reviewed: https://review.openstack.org/513193
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-identity/commit/?id=cbbc525cc43d2435c7a038dbc41b7c283aef3d64
Submitter: Zuul
Branch: master

commit cbbc525cc43d2435c7a038dbc41b7c283aef3d64
Author: Arun S A G <email address hidden>
Date: Wed Oct 18 15:04:59 2017 -0700

    Use the attribute instead of method to get platform_family

    Other cookbooks have switched to using the node attribute
    https://github.com/openstack/cookbook-openstack-common/blob/master/attributes/default.rb#L292
    Using platform_family breaks with chef-client 13.x

    Closes-Bug: #1724987

    Change-Id: I02fcb5d9403210d913e85487de5ef0dae6066bdc

Changed in openstack-chef:
status: In Progress → Fix Released
Revision history for this message
Seb-Solon (openid-3) wrote : Re: [cookbook-openstack-identity] platform_family breaks chef 13.x

Looks like there are still cookbooks using it :

cookbook-openstack-block-storage/attributes/default.rb : https://github.com/openstack/cookbook-openstack-block-storage/blob/master/attributes/default.rb#L74
cookbook-openstack-dns/attributes/default.rb : https://github.com/cloudbau/cookbook-openstack-dns/blob/master/attributes/default.rb#L52
cookbook-openstack-network/attributes/default.rb: https://github.com/openstack/cookbook-openstack-network/blob/master/attributes/default.rb#L156
cookbook-openstack-network/attributes/default.rb: https://github.com/openstack/cookbook-openstack-network/blob/master/attributes/default.rb#L176
cookbook-openstack-network/attributes/default.rb: https://github.com/openstack/cookbook-openstack-network/blob/master/attributes/default.rb#L222
cookbook-openstack-orchestration/attributes/default.rb : https://github.com/openstack/cookbook-openstack-orchestration/blob/master/attributes/default.rb#L66
cookbook-openstack-telemetry/attributes/default.rb : https://github.com/openstack/cookbook-openstack-telemetry/blob/master/attributes/default.rb#L90

The DNS one may not be on your side by the way

Do we reopen this bug or create a new one ?

Revision history for this message
Samuel Cassiba (scassiba) wrote :

openstack-dns is under our umbrella, just not housed on OpenStack's Gerrit. I've filed https://blueprints.launchpad.net/openstack-chef/+spec/modern-chef to cover the full scope.

Changed in openstack-chef:
status: Fix Released → Confirmed
summary: - [cookbook-openstack-identity] platform_family breaks chef 13.x
+ [all] platform_family breaks chef 13.x
Samuel Cassiba (scassiba)
no longer affects: openstack-chef/pike
Changed in openstack-chef:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-block-storage (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515255

Changed in openstack-chef:
assignee: Arun S A G (sagarun) → Seb-Solon (openid-3)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-compute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515256

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-image (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515257

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-network (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515258

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-orchestration (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515259

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-telemetry (master)

Fix proposed to branch: master
Review: https://review.openstack.org/515260

Revision history for this message
Seb-Solon (openid-3) wrote :

For the record I did a pull request on the DNS repo in github (if I'm not wrong it is the right place) : https://github.com/cloudbau/cookbook-openstack-dns/pull/7

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-image (master)

Reviewed: https://review.openstack.org/515257
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-image/commit/?id=9186e1262f7159a40b2b2d76c6bb5aded41bdda4
Submitter: Zuul
Branch: master

commit 9186e1262f7159a40b2b2d76c6bb5aded41bdda4
Author: Seb-Solon <email address hidden>
Date: Thu Oct 26 12:42:07 2017 -0400

    Replace platform_family method and use attribute instead

    platform_family method is not working on latest Chef versions

    Change-Id: I7e7fb5c51e97f3e4186a5f735f4fd8285934e0f0
    Partial-Bug: #1724987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-block-storage (master)

Reviewed: https://review.openstack.org/515255
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-block-storage/commit/?id=a0ad02e3966440c525eefc632ccc11b840ac2140
Submitter: Zuul
Branch: master

commit a0ad02e3966440c525eefc632ccc11b840ac2140
Author: Sebastien Coavoux <email address hidden>
Date: Wed Oct 25 22:00:26 2017 -0400

    Replace platform_family method and use attribute instead

    platform_family method is not working on latest Chef versions

    Change-Id: I2b908180fc42265146f8b50ecbdb1e002f6d218b
    Partial-Bug: #1724987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-network (master)

Reviewed: https://review.openstack.org/515258
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-network/commit/?id=3b6c8c04e0cf8a35afa0f9f0944072a02e456cbf
Submitter: Zuul
Branch: master

commit 3b6c8c04e0cf8a35afa0f9f0944072a02e456cbf
Author: Seb-Solon <email address hidden>
Date: Thu Oct 26 12:43:33 2017 -0400

    Replace platform_family method and use attribute instead

    platform_family method is not working on latest Chef versions

    Change-Id: I364ba316dd91cf11cc813f0c642708fd46cd6caf
    Depends-On: Ibfc34ec195950e844c6e5b939708bb0ef7411029
    Partial-Bug: #1724987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-compute (master)

Reviewed: https://review.openstack.org/515256
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-compute/commit/?id=638c651975bb4142bf6b00c21f01b808854eeb05
Submitter: Zuul
Branch: master

commit 638c651975bb4142bf6b00c21f01b808854eeb05
Author: Seb-Solon <email address hidden>
Date: Thu Oct 26 12:39:22 2017 -0400

    Replace platform_family method and use attribute instead

    platform_family method is not working on latest Chef versions

    Change-Id: I65f1c8a6daffada15406c55a48643fe134794aa7
    Partial-Bug: #1724987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-orchestration (master)

Reviewed: https://review.openstack.org/515259
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-orchestration/commit/?id=d8f3af044efcac7865ca8433745dcc6e1456e9fd
Submitter: Zuul
Branch: master

commit d8f3af044efcac7865ca8433745dcc6e1456e9fd
Author: Seb-Solon <email address hidden>
Date: Thu Oct 26 12:44:59 2017 -0400

    Replace platform_family method and use attribute instead

    platform_family method is not working on latest Chef versions

    Change-Id: I527f6ec23b38e149d51f00e7a214aded95a14bd8
    Partial-Bug: #1724987

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-telemetry (master)

Reviewed: https://review.openstack.org/515260
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-telemetry/commit/?id=994abe45513cc1e7dc28f81a177527dcfb607b8e
Submitter: Zuul
Branch: master

commit 994abe45513cc1e7dc28f81a177527dcfb607b8e
Author: Seb-Solon <email address hidden>
Date: Wed Oct 25 21:26:26 2017 -0400

    Replace platform_family method and use attribute instead

    Change-Id: I1cc48f0cf67aee76372b69f86323210c933f67fd
    Closes-Bug: #1724987

Changed in openstack-chef:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.