Web Client unable to edit users with ident_type2 field set

[Jason Boyer]

Eg 3.0

The ident_type2 field isn't handled in the webstaff user editor so while you can set an ident_value2 you can't say what it is and because of the way this is handled an account with a non-null ident_type2 field can't be edited. When you click Save it just sits and nothing happens (unless you're watching the error console).

Because this field isn't handled in the same way as ident_type1 the cstore backend that tries to save it dies quietly and there's no indication of what happened except a line about "drone_blah_blah IS NOT CONNECTED TO THE NETWORK!" shortly thereafter. This is because the ident_type1 field is passed as a number but the ident_type2 is sent as an object. So the au object passed to the cstore drone looks like this: ...,3,{"id":3,"name":"Other"},"value1","value2"... and it just dies.

Patch incoming to handle ident_type2 the same way as ident_type1, though it won't make cstore any more resilient against this sort of type mismatch.

[Jason Boyer (jboyer)]

A wild branch appears!
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1724725-user-editor-ident_type2

Use PullRequest.

It's super effective!

[Galen Charlton (gmc)]

Pushed to master, rel_3_0, and rel_2_12. Thanks, Cesar!