Ocata to Pike upgrade: running upgrade-non-controller.sh script for a split stack compute node fails because tripleo-ansible-inventory is using the heat-admin user instead of 'stack'

[Marios Andreou]

As discussed at https://bugzilla.redhat.com/show_bug.cgi?id=1503247 for Ocata to Pike upgrade in a split stack environment, we need to be able to override the overcloud admin user in the tripleo ansible inventory passed to the ansible-playbok invocation in upgrade-non-controller.sh

To overcome this we can generate and use a static inventory so that we can specify a --ansible_ssh_user

Patch posted here https://review.openstack.org/#/c/512999/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512999
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=07587f6b02762e5b3d7c9499c0ee8ccb1881e06e
Submitter: Zuul
Branch: master

commit 07587f6b02762e5b3d7c9499c0ee8ccb1881e06e
Author: marios <email address hidden>
Date: Wed Oct 18 13:36:32 2017 +0300

    Get a static inventory for upgrade-non-controller ansible runs

    This is mainly used together with the newly added --overcloud-user
    option and allows us to specify a custom overcloud admin user
    e.g. in split stack environments 'stack' vs 'heat-admin'. The
    static inventory is generated with the specified user.

    As a further optimisation this also adds a new --inventory (-I)
    option with which a previously generated inventory can be
    specified.

    This is also expected to be more efficient since we now only
    generate the inventory at most once per node/invocation.

    Change-Id: If0d5ca461ce6faf84c26a75bf9ab9e72bb061e7a
    Closes-Bug: 1724552

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/514951

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/514951
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=957b40e0094501ca57caa0d58043c555b39d05e0
Submitter: Zuul
Branch: stable/pike

commit 957b40e0094501ca57caa0d58043c555b39d05e0
Author: marios <email address hidden>
Date: Wed Oct 18 13:36:32 2017 +0300

    Get a static inventory for upgrade-non-controller ansible runs

    This is mainly used together with the newly added --overcloud-user
    option and allows us to specify a custom overcloud admin user
    e.g. in split stack environments 'stack' vs 'heat-admin'. The
    static inventory is generated with the specified user.

    As a further optimisation this also adds a new --inventory (-I)
    option with which a previously generated inventory can be
    specified.

    This is also expected to be more efficient since we now only
    generate the inventory at most once per node/invocation.

    Change-Id: If0d5ca461ce6faf84c26a75bf9ab9e72bb061e7a
    Closes-Bug: 1724552
    (cherry picked from commit 07587f6b02762e5b3d7c9499c0ee8ccb1881e06e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.2.0 release.