'zoning_mode' value is always none

Bug #1724418 reported by TommyLike
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
TommyLike

Bug Description

We can not read the value of 'zoning_mode' now, because we moved this option from 'default' to 'backend_defaults' in this patch [1] while keep reading it from the default secion [2].

[1]: https://review.openstack.org/#/c/453654/
[2]: https://github.com/openstack/cinder/blob/master/cinder/zonemanager/utils.py#L55

TommyLike (hu-husheng)
Changed in cinder:
assignee: nobody → TommyLike (hu-husheng)
Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/514555

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/512208
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=34287e3fa351db5e5b00cd0cf1affac07d9e6d34
Submitter: Zuul
Branch: master

commit 34287e3fa351db5e5b00cd0cf1affac07d9e6d34
Author: TommyLike <email address hidden>
Date: Mon Oct 16 15:59:00 2017 +0800

    Move 'zoning_mode' back to DEFAULT section

    We moved 'zoning_mode' option to 'backend_defaults'
    section since patch: [1]. But it has two issues:

    1. It can not work because we still fetch the value
    from the default section [2].
    2. From the view of our current design. It's only
    used in our framework code, which means it still can
    not work if we overwrite the default value in one
    specific backend section, such as:

    [backend_defaults]
    zoning_mode=fabric
    [lvmbackend_1]
    zoning_mode=other_value

    Move this option back to DEFAULT section until we
    need to.

    Closes-Bug: #1724418

    [1]: https://review.openstack.org/#/c/453654/
    [2]: https://github.com/openstack/cinder/blob/master/cinder/zonemanager/utils.py#L56

    Change-Id: I5b31082296f5bff5089d0f42a62d44bb009d177d

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/pike)

Reviewed: https://review.openstack.org/514555
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=85a963a5c68a12efe7a7251689028e0b2bd398a9
Submitter: Zuul
Branch: stable/pike

commit 85a963a5c68a12efe7a7251689028e0b2bd398a9
Author: TommyLike <email address hidden>
Date: Mon Oct 16 15:59:00 2017 +0800

    Move 'zoning_mode' back to DEFAULT section

    We moved 'zoning_mode' option to 'backend_defaults'
    section since patch: [1]. But it has two issues:

    1. It can not work because we still fetch the value
    from the default section [2].
    2. From the view of our current design. It's only
    used in our framework code, which means it still can
    not work if we overwrite the default value in one
    specific backend section, such as:

    [backend_defaults]
    zoning_mode=fabric
    [lvmbackend_1]
    zoning_mode=other_value

    Move this option back to DEFAULT section until we
    need to.

    Closes-Bug: #1724418

    [1]: https://review.openstack.org/#/c/453654/
    [2]: https://github.com/openstack/cinder/blob/master/cinder/zonemanager/utils.py#L56

    Change-Id: I5b31082296f5bff5089d0f42a62d44bb009d177d
    (cherry picked from commit 34287e3fa351db5e5b00cd0cf1affac07d9e6d34)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 11.0.1

This issue was fixed in the openstack/cinder 11.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 12.0.0.0b2

This issue was fixed in the openstack/cinder 12.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.