[2.3, HWTv2] Aborted test should not show as failure
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Newell Jensen |
Bug Description
Aborted tests should never show as failure. For example, I did this:
1. started smartctl-validate testing
2. aborted the tests
3. started smartctl-validate
4. waited for it to successfully finish
In the machine listing page, it shows as failure for the 'disk' and the label shows:
"1 test passed. 1 test was aborted"
So there’s two issues:
1. The machine listing page is marking disks as failed with the message above, when the last run of the tests succeeded but a previous run was aborted. This should never consider previous runs of the tests, only the latest one to mark the status.
2. Aborted test is being considered as failure. If someone aborts a test, it should t be shown as the test has failed!
Related branches
- Andres Rodriguez (community): Approve
- Lee Trager (community): Needs Fixing
-
Diff: 103 lines (+36/-8)2 files modifiedsrc/maasserver/websockets/handlers/node.py (+11/-3)
src/maasserver/websockets/handlers/tests/test_machine.py (+25/-5)
Changed in maas: | |
importance: | Undecided → High |
milestone: | none → 2.3.0beta3 |
status: | New → Triaged |
Changed in maas: | |
assignee: | nobody → Newell Jensen (newell-jensen) |
description: | updated |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |