xfce4-session doesn't check for reboot correctly

[Owen Dunn]

xfce4-session 4.12.1-3ubuntu1

xfce4-session determines which buttons to grey out on the logout dialogue box by calling
polkit_check_authorization_sync for the action org.freedesktop.login1.reboot etc.

However, if polkit policy permits these actions but denies org.freedesktop.login1.reboot-multiple-sessions, and multiple users are logged in, the restart button on the logout dialogue box will be enabled even though the user isn't able to reboot the machine.

xfce4-session should instead use the CanReboot (etc.) methods on systemd-logind, which will automatically correctly check the correct polkit permissions.

I attach a patch to xfsm-systemd.c which works for me.

(S)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Patch to xfsm-systemd.c" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Theo Linkspfeifer (lastonestanding)]

Please forward this patch to the Xfce bug tracker. Thanks.

https://bugzilla.xfce.org/

[Theo Linkspfeifer (lastonestanding)]

Created attachment 7984
Patch to xfsm-systemd.c

Forwarded from https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1724196

---
xfce4-session 4.12.1-3ubuntu1

xfce4-session determines which buttons to grey out on the logout dialogue box by calling
polkit_check_authorization_sync for the action org.freedesktop.login1.reboot etc.

However, if polkit policy permits these actions but denies org.freedesktop.login1.reboot-multiple-sessions, and multiple users are logged in, the restart button on the logout dialogue box will be enabled even though the user isn't able to reboot the machine.

xfce4-session should instead use the CanReboot (etc.) methods on systemd-logind, which will automatically correctly check the correct polkit permissions.

I attach a patch to xfsm-systemd.c which works for me.

(S)

[Marcos Felipe Mello (marcosfrm)]

Your patch will probably fix bug #13699 too.

[Marcos Felipe Mello (marcosfrm)]

Can anyone take a look at this patch? Let's put it in xfce4-session 4.13.x for better testing!

[Marcos Felipe Mello (marcosfrm)]

Created attachment 8416
Use logind Can* methods

Patch updated to git master plus style fixes.

[Marcos Felipe Mello (marcosfrm)]

Tested it on Arch Linux with xfce4-session-4.13.1git-5a42eda8 and can confirm it fixes bug 13699 too.

[Marcos Felipe Mello (marcosfrm)]

Created attachment 8417
Use logind Can* methods (V2)

One more style fix.

[Theo Linkspfeifer (lastonestanding)]

*** Bug 13699 has been marked as a duplicate of this bug. ***

[Marcos Felipe Mello (marcosfrm)]

Created attachment 8421
Use logind Can* methods (V3)

Very old logind versions (< 196) do not support CanHybridSleep method. In this case g_dbus_connection_call_sync() will return NULL and g_variant_get() will explode. Hence test if dbus_ret != NULL.

(sorry, previous patches were mangled somehow)

[Marcos Felipe Mello (marcosfrm)]

Fix also needed in xfce4-power-manager:

https://git.xfce.org/xfce/xfce4-power-manager/tree/src/xfpm-systemd.c#n116

[Gitbot (gitbot)]

Simon Steinbeiss referenced this bugreport in commit e10ac91be3301c92900168855b265101ba9884e2

Use systemd-logind methods instead of polkit permissions (Bug #14707)

https://git.xfce.org/xfce/xfce4-session/commit?id=e10ac91be3301c92900168855b265101ba9884e2

[Simon Steinbeiß (ochosi)]

Merged it in, let's test this properly.

[Sean Davis (bluesabre)]

Fixed in release 4.13.2.