tripleo releases are promoted prior to the image upload

[wes hayutin]

The dlrn_api is reporting success prior to the images being uploaded :(

https://github.com/openstack-infra/tripleo-ci/commit/54ff19633e587bd8e2bfd8308780098ef7b7b2dc

The uploader is currently failing on:
https://review.rdoproject.org/r/#/c/10128/1/jobs/tripleo-upstream.yml

So we're getting promotions w/o images, which is a very dangerous thing to do.
You can see this happening here:
https://review.rdoproject.org/jenkins/job/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset002-pike-upload/163/consoleFull

TO-DO:
Ensure there are two templates and builders for tripleo promotion jobs

* where one template/builder is used for all the jobs and calls the dlrnapi_client in builder than is run after everthing else.

* the upload-label builder will continue to be used, but add the dlrnapi_client script to be called after the these lines:
export RELEASE={release}
bash -xe $WORKSPACE/rdo-infra/ci-config/ci-scripts/tripleo-upstream/convert-upload-undercloud.sh
bash -xe $WORKSPACE/rdo-infra/ci-config/ci-scripts/tripleo-upstream/upload-cloud-images.sh

reference:
https://review.rdoproject.org/r/#/c/10128/1/jobs/tripleo-upstream.yml

[Gabriele Cerami (gcerami)]

Trying a post build approach

https://review.rdoproject.org/r/10180
https://review.openstack.org/512590

[Gabriele Cerami (gcerami)]

Added also https://review.rdoproject.org/r/10181

[Gabriele Cerami (gcerami)]

some variable were missing
added https://review.rdoproject.org/api/10190 and https://review.rdoproject.org/r/10189

[wes hayutin (weshayutin)]

https://review.rdoproject.org/r/#/c/10240/
https://review.rdoproject.org/r/#/c/10216/