Web Client: Offline working location dropdown not sorted

[Terran McCanna]

The working location dropdown list of shortnames isn't sorted alphabetically at the system level or by branch within each system grouping. Being in a system with 54 going on 55 systems, that makes it extremely difficult to navigate.

[Joan Kranich (jkranich)]

Evergreen 3.0.6

We find the working location dropdown list is not sorted in some sections and also some locations are missing from the list. We have over 300 org units.

[Terran McCanna (tmccanna)]

Still not sorted alphabetically in 3.1.

[Mike Risher (mrisher)]

I've pushed a branch with a fix.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1724019-offline-location-dropdown

[Dawn Dale (ddale)]

I have tested this code and consent to signing off on it with my name, Dawn Dale and my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Although it does alphabetize now, it has lost the hierarchy - see attached screenshot where you can see, for example, that CONS is down in the middle. Removing the pullrequest.

[Mike Risher (mrisher)]

This was done intentionally because my understanding is that was what was being requested. Could you help me understand the desired behavior?

[Terran McCanna (tmccanna)]

It should have the same hierarchy that the org units have - consortium level first, systems alphabetical under that, branches alphabetical within their systems.

The way it is done on the "Register a New Workstation" screen is good (hierarchy.jpg).

The way it is done on the patron edit screen is even better because it also grays out the consortium and system levels and only allows branches to be selected (hierarchy2.jpg).

[Terran McCanna (tmccanna)]

Here is what it currently looks like in production - the hierarchy is there, but the systems aren't in order and the branches within each system aren't in order, so it's difficult to find the one you are looking for.

[Kyle Huckins (khuckins)]

Noting with relation to hierarchy2 - the Angular Org Selector doesn't currently support graying out of consortium/system-level orgs, but the functionality to do so will be present with bug 1863168

[Mike Risher (mrisher)]

I re-did this work to preserve the org hierarchy when alphabetizing. Here's the branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1724019-offline-location-dropdown-orgs

[Terran McCanna (tmccanna)]

Thanks, Mike! Works as expected now. My signoff at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1724019-offline-location-dropdown-orgs-signoff

[Jane Sandberg (sandbergja)]

Thanks, Mike. The patch works for me. However, I don't think we should have two separate sorting methods depending on whether or not the org selector is in the offline client or not. I haven't tried it yet, but it seems like we could make a few changes to egEnv's (or maybe the lovefield service's) logic to use the existing sort_aou for offline calls as well. https://github.com/evergreen-library-system/Evergreen/blob/7c3cdbbd140865e07d08952422c82605ac8c5676/Open-ILS/web/js/ui/default/staff/services/env.js#L183

That way, the org selector could just make the assumption that it is getting correctly sorted data.

Thoughts?

[Mike Risher (mrisher)]

Thanks for pointing out that sort_aou function, Jane. I agree we don't want to repeat code if we can help it. With some help, I changed the approach so that it's now using that function. Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1724019-offline-org-alphabetize

[Bill Erickson (berick)]

Issue and fix confirmed, now with shared sort. Merged to 3.4 and up. Thanks, all.