Crash in bzr8464[trunk] from SoundHandler::load_one_fx

[Klaus Halfmann]

I freshly compiled widelands trunk and wanted to play galicer lage as red
ans an intern game. As defined by the Widelands tournament 2017: official announcements https://wl.widelands.org/forum/topic/2912/

Important: I upgraded to OSX-High Sierra (10.13) but I think it was ok before.
This is bzr8464[trunk]

I got a version bzr8463[trunk] from MacPorts which crashes at the same location.
R19 is not affected so I do not want to blame high sierrea by now.

Apple crash reports shows:

0 libSDL2-2.0.0.dylib 0x00000001055f54e0 SDL_ResampleAudio + 804
1 libSDL2-2.0.0.dylib 0x00000001055f5164 SDL_ResampleCVT + 221
2 libSDL2-2.0.0.dylib 0x00000001055f366c SDL_ConvertAudio_REAL + 39
3 libSDL2_mixer-2.0.0.dylib 0x00000001056bef75 Mix_LoadWAV_RW + 795
4 widelands 0x0000000103f3ff9f SoundHandler::load_one_fx(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 671 (sound_handler.cc:282)
5 widelands 0x0000000103f3f60f SoundHandler::load_fx_if_needed(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 3743 (sound_handler.cc:259)
6 widelands 0x0000000103aab526 (anonymous namespace)::NonPackedAnimation::NonPackedAnimation(LuaTable const&) + 3798 (animation.cc:120)
7 widelands 0x0000000103aa9aed (anonymous namespace)::NonPackedAnimation::NonPackedAnimation(LuaTable const&) + 29 (animation.cc:165)
8 widelands 0x0000000103aa9484 AnimationManager::load(LuaTable const&) + 116 (animation.cc:323)

So either some new audio or some change in SDL caused this?

SirVer: can you confirm

[SirVer (sirver)]

This is bug 1720819, you need an sdl & sdl mixer compiled from the current HEAD of their repositories. The released versions are buggy.

[Klaus Halfmann (klaus-halfmann)]

I rolled back to libsdl2 2.0.5 as described in

https://trac.macports.org/wiki/howto/InstallingOlderPort

Using this Portfile:

https://github.com/macports/macports-ports/tree/a7cce14bd2b3afe0e5fb7b3d2aa0d0cf7281c439/devel/libsdl2

This actually did the truck, it was not necessary to downgrade libsl2_mixer

[Klaus Halfmann (klaus-halfmann)]

Macports was updated to

libsdl2 @2.0.7_0
libsdl2_image @2.0.2_0
libsdl2_mixer @2.0.2_0

compiled bzr8467[trunk]semm ok agaain.