Tests don't correctly cleanup in case of an error

[Michel Peterson]

There are several contexts that are affected. An example is the `bgpvpn()` context [1], where the yield [2] is not surrounded by a correct error management and therefore if a test asserts an error and it fails to assert the bgpvpn won't get deleted, as the delete is after the yield.

[1]: https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/tests/unit/services/test_plugin.py#L116
[2] https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/tests/unit/services/test_plugin.py#L130

This should be modified to something like

"""
try:
    yield bgpvpn
finally:
    self.__delete(...)
"""

This same fix should be applied to all affected contexts.

[Cedric Savignan (csavignan)]

The autodeletion is not mandatory? The database is deleted after each test?
https://specs.openstack.org/openstack/neutron-specs/specs/juno/remove-unit-test-autodeletion.html

[Michel Peterson (mpeterson)]

Even if that's the case, the codebase is not following the guidelines there. Disregarding that, for example in the case of networking-odl this has a real impact, since ODL is not part of the cleanup of that DB; but I guess this needs to be contemplated in networking-odl, given the document you pointed to.