overcloud config download writes malformed step_config.pp

[Steven Hardy]

The output manifest is joined a character at a time by "\n", but the output data already has newlines in it.

To reproduce do:

openstack overcloud config download
vim /home/stack/tripleo-xxxx-config/Controller/step_config.pp

This file isn't actually consumed by ansible atm so deploy still works (including when driven via ansible-playbook) but it'd be good to fix so we can make use of the manifest in future.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/511516

[Steven Hardy (shardy)]

Ok so discussion on the review indicates this will be fixed via https://review.openstack.org/#/c/510131/ combined with https://review.openstack.org/#/c/487488/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steven Hardy (<email address hidden>) on branch: master
Review: https://review.openstack.org/511516
Reason: Ok so discussion on the review indicates this will be fixed via https://review.openstack.org/#/c/510131/ combined with https://review.openstack.org/#/c/487488/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/512991

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/487488
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=8a7da9fe26e8b8db6ee26dfdae940f36c9b55488
Submitter: Zuul
Branch: master

commit 8a7da9fe26e8b8db6ee26dfdae940f36c9b55488
Author: Mathieu Bultel <email address hidden>
Date: Wed Jul 26 17:40:46 2017 +0200

    Implement minor update workflow with config download

    This change aim to refactor the way of doing the minor upgrade
    via ansible playbook download by the config download
    It will depend on a mistral change which will get the
    ansible update_task and run it via mistral
    The user will have two ways for performing the minor update:
      - the stack update command which will make an automatic minor
        upgrade (or just upgrade a given set of nodes)
      - running it manually via ansible on the undercloud

    Closes-Bug: #1715557
    Closes-Bug: #1723108
    Change-Id: I4fcd443d975894a1da0286b19506d00682c5768c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512991
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=153bc4fab3ff74d346248c34399022891a0aa8c5
Submitter: Zuul
Branch: stable/pike

commit 153bc4fab3ff74d346248c34399022891a0aa8c5
Author: Mathieu Bultel <email address hidden>
Date: Wed Jul 26 17:40:46 2017 +0200

    Implement minor update workflow with config download

    This change aim to refactor the way of doing the minor upgrade
    via ansible playbook download by the config download
    It will depend on a mistral change which will get the
    ansible update_task and run it via mistral
    The user will have two ways for performing the minor update:
      - the stack update command which will make an automatic minor
        upgrade (or just upgrade a given set of nodes)
      - running it manually via ansible on the undercloud

    Closes-Bug: #1715557
    Closes-Bug: #1723108
    Change-Id: I4fcd443d975894a1da0286b19506d00682c5768c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 8.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 7.3.3 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510131
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=369de46742eafeff004cdf1277b551d948af78ee
Submitter: Zuul
Branch: master

commit 369de46742eafeff004cdf1277b551d948af78ee
Author: Mathieu Bultel <email address hidden>
Date: Fri Oct 6 16:11:40 2017 +0200

    Fix step_config output which is str not list

    The step_config from role_data is a string and
    not a list, the current step_config.pp is broken

    Closes-Bug: #1723108

    Change-Id: Ia91eee6d810425ecd332883785b0f6aa3c482bb8

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.3.0 release.