We should stop the deployment if on upgrade there is stale hieradata for puppet-ceph

[Giulio Fidente]

The ceph-ansible profiles should halt the deployment if there is stale hieradata for puppet-ceph in ExtraConfig because that can't be automatically converted into ceph-ansible variables

In particular ceph::profile::params::osds which used to provide the list of disks to be used as OSDs needs to be converted into the ceph-ansible 'devices' variable or we are at risk of destroying the Ceph cluster!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/511474

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/518698

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/520017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/518698
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ee10ae9f6ee5a1b74ea52c1bb69c06083caa31de
Submitter: Zuul
Branch: master

commit ee10ae9f6ee5a1b74ea52c1bb69c06083caa31de
Author: Giulio Fidente <email address hidden>
Date: Thu Nov 9 11:09:37 2017 +0100

    Fail on upgrade if legacy ceph::profile::params::osds hiera is found

    We should stop the deployment if there is certain stale puppet-ceph
    hieradata because if it isn't converted into ceph-ansible variables
    the latter could break the deployment using wrong defaults.

    Change-Id: Ice2e79a4a3b9a2427b706ec888d6bb8bcca2c542
    Related-Bug: #1723085

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/520577

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/520017
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dbe279af47aedae0f56bab3e64233ba9ae6ac5e0
Submitter: Zuul
Branch: stable/pike

commit dbe279af47aedae0f56bab3e64233ba9ae6ac5e0
Author: Giulio Fidente <email address hidden>
Date: Thu Nov 9 11:09:37 2017 +0100

    Fail on upgrade if legacy ceph::profile::params::osds hiera is found

    We should stop the deployment if there is certain stale puppet-ceph
    hieradata because if it isn't converted into ceph-ansible variables
    the latter could break the deployment using wrong defaults.

    Change-Id: Ice2e79a4a3b9a2427b706ec888d6bb8bcca2c542
    Related-Bug: #1723085
    (cherry picked from commit ee10ae9f6ee5a1b74ea52c1bb69c06083caa31de)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/511474
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8c90ee5d46b6e4d0ebfc032591e0dbeb82589bbb
Submitter: Zuul
Branch: master

commit 8c90ee5d46b6e4d0ebfc032591e0dbeb82589bbb
Author: Giulio Fidente <email address hidden>
Date: Thu Oct 12 15:00:36 2017 +0200

    Fail ceph-ansible workflow if there is stale puppet-ceph hieradata

    We should stop the deployment if there is stale puppet-ceph
    hieradata because it isn't converted automatically into
    ceph-ansible variables.

    Initially we only stop the deployment if ceph::profile::params::osds
    is found to make sure operators have converted that into a ceph-ansible
    parameter and removed it from the Heat environment file.

    Change-Id: I6031625b128b989c78f20350d2971cc61bf874b1
    Closes-Bug: #1723085

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/520577
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=54f323bc9f412b7f844d551100bbe609406c2dd8
Submitter: Zuul
Branch: stable/pike

commit 54f323bc9f412b7f844d551100bbe609406c2dd8
Author: Giulio Fidente <email address hidden>
Date: Thu Oct 12 15:00:36 2017 +0200

    Fail ceph-ansible workflow if there is stale puppet-ceph hieradata

    We should stop the deployment if there is stale puppet-ceph
    hieradata because it isn't converted automatically into
    ceph-ansible variables.

    Initially we only stop the deployment if ceph::profile::params::osds
    is found to make sure operators have converted that into a ceph-ansible
    parameter and removed it from the Heat environment file.

    Change-Id: I6031625b128b989c78f20350d2971cc61bf874b1
    Closes-Bug: #1723085
    (cherry picked from commit 8c90ee5d46b6e4d0ebfc032591e0dbeb82589bbb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.2.0 release.