overcloud container image prepare --env-file overwrites unconditionally

[plieb]

overcloud container image prepare --env-file overwrites the target file unconditionally.

This is a problems because the env-file is required to reproduce a containerized deployment.

It might also contain extra parameter_defaults such as:

DockerInsecureRegistryAddress: 172.16.0.1:8787

If you overwrite the environment file but do not include some of the required Heat environments, or include wrong versions, you could break you deployment various ways.

This bug could be addressed by automatically backing up the prior environment file and/or prompting before overwriting the exiting environment file.

It may also be a bug that --images-file also overwrites unconditionally.

OpenStack Pike

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/609694

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/609694
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=4b43155648d7bb4c0fefff259303eff3b03eaa4a
Submitter: Zuul
Branch: master

commit 4b43155648d7bb4c0fefff259303eff3b03eaa4a
Author: David J Peacock <email address hidden>
Date: Thu Oct 11 08:56:41 2018 -0400

    check for existence of output env file for container image prepare

    Currently, `overcloud container image prepare --env-file` will clobber
    any existing file, which can present a problem.

    This patch catches this scenario, moves the existing --env-file to a
    backup, and then continues with the creation.

    Change-Id: I3d88ab7a948a1e14940542964824a3bbc1a94fa6
    Closes-Bug: 1723071

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.2.0 release.