Trailing spaces cause located URIs to be invalid
Bug #1722827 reported by
Jane Sandberg
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Low
|
Unassigned | ||
3.1 |
Fix Released
|
Low
|
Unassigned | ||
3.2 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Per Don Butterworth:
"if you unintentionally add a blank space after the text of a subfield 9 in the 856 field, Evergreen doesn't recognize the code as valid, and it will not display the 856 fields on the Record Summary screen and the title will not show up in the OPAC."
Changed in evergreen: | |
assignee: | nobody → Meg Stroup (mstroup) |
assignee: | Meg Stroup (mstroup) → nobody |
tags: |
added: pullrequest removed: needsrepatch |
tags: | added: signedoff |
Changed in evergreen: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in evergreen: | |
milestone: | none → 3.3.1 |
Changed in evergreen: | |
milestone: | 3.3.1 → 3.3.2 |
Changed in evergreen: | |
milestone: | 3.3.2 → 3.3.3 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Jane,
I was looking at this and the core issue is that a space at the beginning or end of a name could theoretically be a valid org unit name. I question why anyone would do that but .... there are more things in heaven and earth than dreamt of in my philosophies.
Still, if we want to trim surrounding spaces from it this should do it:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=blobdiff; f=Open- ILS/src/ sql/Pg/ 030.schema. metabib. sql;h=17b39fbcc 380737d01c5f309 d4bb2feb6b54558 9;hp=bc72c89601 7f793b21623132d a28b20f0ec76d3f ;hb=d9f0334c29b 242f27bf8f6b853 81595c7e2719c9; hpb=d6a247f3847 fa26e8e5cadf8cd 92ff573a828584
/user/rogan/ lp1722827_ trim_spaces_ from8569s
FWIW, I think this is worth doing, barring anyone pointing out use cases it would break and it worked in my (admittedly brief) testing.