Quotas per share_type has bad db unique contraint

[Sam Morrison]

The unique constraint on the project_share_type_quotas makes it essentially impossible to use.

UNIQUE KEY `uc_quotas_per_share_types` (`share_type_id`,`resource`,`deleted`),

It needs to take into account project_id so more than one project can have per share-type quotas.

This will fix it:

ALTER TABLE project_share_type_quotas
   DROP INDEX `uc_quotas_per_share_types`,
   ADD UNIQUE KEY `uc_quotas_per_share_types` (`share_type_id`,`resource`,`deleted`, project_id);

[Dustin Schoenbrun (dschoenb)]

Hey Valeriy, Tom was telling me that you'd worked on the quotas stuff in the past; what do you think about this one? Thanks!

[Sam Morrison (sorrison)]

I've been trying to figure out in alembic how to do a drop and add index in the same alter table command, can't do a drop then an add as it violates a foreign key somehow

ALTER TABLE project_share_type_quotas DROP INDEX `uc_quotas_per_share_types`;
ERROR 1553 (HY000): Cannot drop index 'uc_quotas_per_share_types': needed in a foreign key constraint

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/511753

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/518900

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/518900
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=91dbbb4d156ec29e79b1ab8698bfc382d59a3c2d
Submitter: Zuul
Branch: stable/pike

commit 91dbbb4d156ec29e79b1ab8698bfc382d59a3c2d
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Oct 13 10:54:05 2017 +0300

    Fix 'project_share_type_quotas' DB table unique constraint

    It should be possible to use share type quotas in each project/tenant.
    But we get error trying to set share types quota in second+ project
    for the same share type. It happens so due to the bug in DB schema,
    where we don't have 'project_id' in unique constraint.
    So, add new DB migration that fixes unique constraint and cover it with
    DB and tempest tests.

    Change-Id: I1405ced4e12b40904b7227c9f6285e2775005f8a
    Closes-Bug: #1722707
    (cherry picked from commit 7ba41320f3ee36116d114874cb01d589a92f3291)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/511753
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=7ba41320f3ee36116d114874cb01d589a92f3291
Submitter: Zuul
Branch: master

commit 7ba41320f3ee36116d114874cb01d589a92f3291
Author: Valeriy Ponomaryov <email address hidden>
Date: Fri Oct 13 10:54:05 2017 +0300

    Fix 'project_share_type_quotas' DB table unique constraint

    It should be possible to use share type quotas in each project/tenant.
    But we get error trying to set share types quota in second+ project
    for the same share type. It happens so due to the bug in DB schema,
    where we don't have 'project_id' in unique constraint.
    So, add new DB migration that fixes unique constraint and cover it with
    DB and tempest tests.

    Change-Id: I1405ced4e12b40904b7227c9f6285e2775005f8a
    Closes-Bug: #1722707

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 6.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 5.0.2 release.