MIGRATION_AUTH_TYPES does not contain the default auth type

[Chris MacNaughton]

The default migration-auth-type from config.yaml is None, which causes a config-changed failure when this is not set: https://pastebin.ubuntu.com/25712193/

The MIGRATION_AUTH_TYPES is from https://github.com/openstack/charm-nova-compute/blob/master/hooks/nova_compute_hooks.py#L127 and we can see the default configuration at https://github.com/openstack/charm-nova-compute/blob/master/config.yaml#L128

[Liam Young (gnuoy)]

Given that the default configuration for the charm is

  enable-live-migration:
    type: boolean
    default: False
  migration-auth-type:
    type: string
    default:

which is valid I don't think this bug is critical.

[Chris MacNaughton (chris.macnaughton)]

Updated mojo specs to set this, have patch to nova-compute proposed as well

[David Ames (thedac)]

Marking this as in progress as Chris already has a proposed change up:
https://review.openstack.org/#/c/510770/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510770
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=f21f460dc7a50b65f52c599f0cf1be4f631953a7
Submitter: Zuul
Branch: master

commit f21f460dc7a50b65f52c599f0cf1be4f631953a7
Author: Chris MacNaughton <email address hidden>
Date: Tue Oct 10 08:55:00 2017 +0200

    Change default migration-auth-type from None to ssh

    The default-auth-type only matters when enable-live-migration
    is enabled, so we should make the default value something that
    will deploy a functional cloud without requiring multiple
    config values to be set

    Change-Id: Icadf1ff7ce90a6a757d258c1f1dee70b8c1d6e0c
    Closes-Bug: #1722456