Undercloud defaults to eth0 (should default to eth1)

[Dan Prince]

In commit 2ffc62209bf14b7eb1c8191a8ef65e6b037c9604 (Don't hardcode eth1 for undercloud nic config) we removed the hard coded nic and instead rely on the default value from the NeutronPublicInterface heat parameter.

As NeutronPublicInterface defaults to nic1 in overcloud.j2.yaml this functionally breaks the undercloud defaults as we typically expect eth1 to be the bridged interface used for the control_plane network traffic.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/510212

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510212
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a124dd1a3ff72ef1cfb6ef922abde81c376d426d
Submitter: Zuul
Branch: master

commit a124dd1a3ff72ef1cfb6ef922abde81c376d426d
Author: Dan Prince <email address hidden>
Date: Fri Oct 6 14:54:02 2017 -0400

    our undercloud default nic should be eth1

    In commit 2ffc62209bf14b7eb1c8191a8ef65e6b037c9604 (Don't hardcode eth1
    for undercloud nic config) we removed the hard coded nic and instead
    rely on the default value from the NeutronPublicInterface heat parameter.
    As NeutronPublicInterface defaults to nic1 in overcloud.j2.yaml this
    functionally broke the undercloud defaults as we typically expect eth1
    to be the bridged interface used for the control_plane network traffic.

    This patch sets the correct default again by setting the value
    manually in the undercloud heat environment.

    NOTE: using eth1 per the old hard coded value. Eventually we want
    this to be nic2 but there has been a regression in os-net-config
    which is causing "active nics" not to be detected correctly in
    all cases.

    Change-Id: Idb1e34bd3dff7c6412082ab4201f8e6af35a939d
    Closes-bug: #1721853

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b2 development milestone.