MAAS

[2.3, HWTv2] Overall health status is missing

Bug #1721824 reported by Andres Rodriguez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Lee Trager
MAAS 2.3.0beta3

Bug Description

This is a follow up from: https://bugs.launchpad.net/maas/+bug/1721823

The overall health status of a machine (API/UI) is missing. This means that:

1. If the machine has failed tests, the overall health status should show as such
2. If the machine has failed tests other than CPU/Mem/Storage, it should surface as such (see bug 1721823)
3. If the machine was on "Failed Testing" mode, and then it was "Overridden" by the user, it should surface that the machine has been overridden (and turned Ready).
4. If the machine health is good, it should not surface anything.

So overall status should probably be something like:
1. ok
2. fail
3. overridden # this means that the user overrode the failed status, and should surface this as such.

See original description

Related branches

~ltrager/maas:health_status
MAAS Lander: Needs Fixing
Andres Rodriguez (community): Approve
Diff: 846 lines (+387/-116)
18 files modified
src/maasserver/api/machines.py (+10/-0)
src/maasserver/api/nodes.py (+94/-1)
src/maasserver/api/rackcontrollers.py (+10/-0)
src/maasserver/api/regioncontrollers.py (+10/-0)
src/maasserver/api/tests/test_enlistment.py (+20/-0)
src/maasserver/api/tests/test_machines.py (+5/-5)
src/maasserver/api/tests/test_node.py (+69/-1)
src/maasserver/api/tests/test_rackcontroller.py (+10/-0)
src/maasserver/api/tests/test_regioncontroller.py (+10/-0)
src/maasserver/api/tests/test_tag.py (+10/-10)
src/maasserver/static/js/angular/controllers/node_details.js (+1/-1)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+1/-1)
src/maasserver/static/partials/machines-table.html (+8/-2)
src/maasserver/static/partials/node-details.html (+3/-3)
src/maasserver/websockets/handlers/machine.py (+1/-43)
src/maasserver/websockets/handlers/node.py (+81/-18)
src/maasserver/websockets/handlers/tests/test_device.py (+8/-7)
src/maasserver/websockets/handlers/tests/test_machine.py (+36/-24)
Andres Rodriguez (andreserl)
Changed in maas:
milestone: none → 2.3.0beta3
importance: Undecided → High
status: New → Triaged
Andres Rodriguez (andreserl)
Changed in maas:
assignee: nobody → Lee Trager (ltrager)
description: updated
Revision history for this message
Andres Rodriguez (andreserl) wrote :

For the overall health status we decided:

1. if node goes to failed testing from commissioning/ready, the node get marked "failed testing". User can use "Ignore tests" to override the failed testing and the node needs to be highligted that it was overriden

2. if the node fails testing from deployed, the node goes back automatically to deployed, and the overall health status reflects that test have failed

Revision history for this message
Andres Rodriguez (andreserl) wrote :

So, for the API, the machine health should be indeed provided. From the UI:

1. when tests other than cpu/ram/memory have failed, have the "overall health status" icon should be shown (with proper tooltip). This would fix https://bugs.launchpad.net/maas/+bug/1721823

2. when tests like cpu/ram/memory have failed, the "overall health status" should be *blank* (the same as how it is today).

3. when user has overriden the "failed testing" state (from commissioning/testing/ready), show the "overall health status" icon (with proper tooltip e.g. "tests have failed, but status was overridden" alongside all other icons)

4. when the machine was deployed -> testing -> deployed -> if there are failed tests, it goes back to deployed with the "overall health status" icon

Lee Trager (ltrager)
Changed in maas:
status: Triaged → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.