[3.2.6.0-53~mitaka] BGP session doesn't come up between BGPaaS-client and ctrl node after the BGPaaS Service port range is modified

[Ganesha HV]

I configured a BGPaaS object with 5 VMIs. 3 among those are on the same compute(nodek9).
One of them with IP 10.10.10.4 was selected as the VRRP master and the BGP session was established.

Removed one of the VMI with IP 10.10.10.6 from the BGPaaS config.
Changed the BGP as a Service Port Range to 50000 - 59000.

Now, I see that the BGP session at the VM with IP 10.10.10.4 is not coming up as the ctrl node is rejecting the peering with the following error:

Oct 5 12:00:13.600804 BGP RECV 10.10.10.2+179 -> 10.10.10.100+58776
Oct 5 12:00:13.601191 BGP RECV message type 3 (Notification) length 21
Oct 5 12:00:13.601267 BGP RECV Notification code 6 (Cease) subcode 3 (Peer Unconfigured)
Oct 5 12:00:13.601919 bgp_read_message: peer 10.10.10.2 (External AS 64512): Notification arrived, expected Open
Oct 5 12:00:13.602516 bgp_read_message:2171: NOTIFICATION received from 10.10.10.2 (External AS 64512): code 6 (Cease) subcode 3 (Peer Unconfigured)
Oct 5 12:00:13.605693 bgp_recv: read from peer 10.10.10.2 (External AS 64512) failed: Connection reset by peer

Setup
=====
nodeg25, nodeg26, nodeg27 - ctrl/cfgm
nodeg25 - webUI/Horizon
nodek8, nodek9, nodek10 - compute

[Jeba Paulaiyan (jebap)]

Notes for Release Notes:

BGPaaS object can be shared across multiple VMIs. This feature can be used only for use-cases with same BGPaaS object shared with VMIs from different compute nodes.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37144
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37587
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37722
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37587
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37587
Committed: http://github.com/Juniper/contrail-controller/commit/6267d5b9641fdce8a5db7c6c5b84e11a0e941fd0
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 6267d5b9641fdce8a5db7c6c5b84e11a0e941fd0
Author: sangarshp <email address hidden>
Date: Wed Nov 22 17:57:19 2017 +0530

Update derived ports for shared bgp sessions when port range is
changed

when global BGPaaS port range is changed, derived ports associted with
BGPaaSobject are not updated and it causes BGP session go down.

Made changes to remove stale flow entries and updated derived ports for
each shared BGP session based on new global BGPaaS port range.

Change-Id: I8371ca5c2de50bf04d6406cac755559de6c29b00
closes-bug: #1721705

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/38138
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37722
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/38138
Committed: http://github.com/Juniper/contrail-controller/commit/5cb53ae6b59433cc335e8130e50dcbc53392931e
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 5cb53ae6b59433cc335e8130e50dcbc53392931e
Author: sangarshp <email address hidden>
Date: Tue Dec 5 21:06:43 2017 +0530

Update derived ports for shared bgp sessions when port range is
changed

when global BGPaaS port range is changed, derived ports associted with
BGPaaSobject are not updated and it causes BGP session go down.

Made changes to remove stale flow entries and updated derived ports for
each shared BGP session based on new global BGPaaS port range.

Change-Id: If99f87df266462e5e6aaae39a1201231aadda150
closes-bug: #1721705

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37722
Committed: http://github.com/Juniper/contrail-controller/commit/b67f4f3fe77472ff77cd490481fbcc6724b67e94
Submitter: Zuul (<email address hidden>)
Branch: master

commit b67f4f3fe77472ff77cd490481fbcc6724b67e94
Author: sangarshp <email address hidden>
Date: Wed Dec 6 13:59:13 2017 +0530

iUpdate derived ports for shared bgp sessions when port range is
changed

when global BGPaaS port range is changed, derived ports associted with
BGPaaSobject are not updated and it causes BGP session go down.

Made changes to remove stale flow entries and updated derived ports for
each shared BGP session based on new global BGPaaS port range.

Change-Id: I29a71e4b307c95d9f80b8634fd7f439ebdb6b5a2
closes-bug: #1721705

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/38380
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/38380
Committed: http://github.com/Juniper/contrail-controller/commit/67b3ff902c0971cecf66a4b9360c72ad811d7d48
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 67b3ff902c0971cecf66a4b9360c72ad811d7d48
Author: sangarshp <email address hidden>
Date: Fri Dec 15 16:14:50 2017 +0530

Update derived ports for shared bgp sessions when port range is
changed
retained callback lists and updated the testcase,

Change-Id: I6093420e5c9c67fc457f192514b9b15ea2d38d9e
closes-bug: #1721705

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/38760
Submitter: sangarshan p (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/38760
Committed: http://github.com/Juniper/contrail-controller/commit/3ee2a8dfedaede593321553147b2028a3913d5e3
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 3ee2a8dfedaede593321553147b2028a3913d5e3
Author: sangarshp <email address hidden>
Date: Tue Jan 9 15:15:48 2018 +0530

Update derived ports for shared bgp sessions when port range is
changed

when global BGPaaS port range is changed, derived ports associted with
BGPaaSobject are not updated and it causes BGP session go down.

Made changes to remove stale flow entries and updated derived ports for
each shared BGP session based on new global BGPaaS port range.

Change-Id: If14b8c717b319bd0552080885a6c93386bb391dd
closes-bug: #1721705