Risk of config update to config_volume not triggering container restart

[Martin André]

docker-puppet.py assumes there can be only one config_volume per container [1]. Unfortunately this is not true and we already have examples in t-h-t [2]. This means there is a risk paunch doesn't restart a container after a config update if the hash doesn't correspond to the config_volume that was updated.

One way to solve the issue could be to calculate a hash based on the hashes of all mounted volumes and pass that as TRIPLEO_CONFIG_HASH.

[1] https://github.com/openstack/tripleo-heat-templates/blob/8c1ae8b73ef67f7c36383fb3f3dcf729703e40ce/docker/docker-puppet.py#L86
[2] https://github.com/openstack/tripleo-heat-templates/blob/5dbe1121e98a794ec6a6387ff56ee34314177567/docker/services/cinder-volume.yaml#L132-L133

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/510632

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510632
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8aef24de810b17cb65bed2aaf0884531a0f99027
Submitter: Jenkins
Branch: master

commit 8aef24de810b17cb65bed2aaf0884531a0f99027
Author: Martin André <email address hidden>
Date: Mon Oct 9 18:04:31 2017 +0100

    Take all mounted config_volumes into account

    We need to account for all the mounted config volumes when generating
    the TRIPLEO_CONFIG_HASH in order for paunch to know to restart the
    container when any one of the config_volume gets updated.

    Change-Id: I473a71f49bd446694da48bb5b7b0a49126df7845
    Closes-Bug: #1721306

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.