IDL for config.standing_penalty lacks labels

Bug #1721304 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

The IDL for the class "csp" (config.standing_penalty) doesn't specify any display labels. As a consequence, the web staff patron messages grids (/eg/staff/circ/patron/*/messages) display ugly column names as the labels.

Evergreen 3.0+

Galen Charlton (gmc)
Changed in opensrf:
importance: Undecided → Low
milestone: none → 3.0.1
assignee: nobody → Cesar V (cesardv)
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
milestone: none → 3.0.1
importance: Undecided → Low
Changed in opensrf:
assignee: Cesar V (cesardv) → nobody
milestone: 3.0.1 → none
no longer affects: opensrf
Revision history for this message
Cesar V (cesardv) wrote :
tags: added: pullrequest webstaffclient
Revision history for this message
Mike Rylander (mrylander) wrote :

One suggestion: we should probably drop the question mark from "Ignore Proximity?" as that's a node distance, rather than an one-off switch.

Revision history for this message
Ben Shum (bshum) wrote :

Just a reminder that while bug 1686832 still applies, any changes to the fieldmapper need to be accompanied by i18n POT sync to update the PO templates for fm_IDL, otherwise, we'll have busted Evergreen systems. Noting this for testers of Cesar's work and the committer who eventually adds it in.

Revision history for this message
Cesar V (cesardv) wrote :

Mike, ah I see yeah, it's not a bool. My bad... I'll change that. I'll amend the branch and push -f.

Ben, thanks for noting that!

Revision history for this message
Mike Rylander (mrylander) wrote :

Ben, would you clarify what you mean, and who would be expected to perform the POT syncing action?

Thanks!

Changed in evergreen:
milestone: 3.0.1 → 3.0.2
Galen Charlton (gmc)
Changed in evergreen:
assignee: Cesar V (cesardv) → Galen Charlton (gmc)
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_0. Thanks, Cesar!

I did the POT update by following the steps at https://wiki.evergreen-ils.org/doku.php?id=dev:release_process:evergreen:2.8#translations_i18n in master and rel_3_0, although I only checked in changes to fm_IDL.dtd.pot and webstaff.pot.

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.