assert minimum version of npm required to get web staff client deps

Bug #1720871 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
New
Wishlist
Unassigned

Bug Description

It has been observed that on a Debian Wheezy system that's been around long enough to still have npm 1.4.9 installed, running "npm install" to fetch the web staff client's dependencies fails to bring in angular-sanitize.

https://docs.npmjs.com/files/package.json suggests that we could make two changes to avoid this issue (and potential future issues):

- add to package.json an "engine" declaration that asserts the minimum version of npm required. (We know that 3.10.10 works and that 1.4.9 does not)
- passing '--engine-strict true' to the npm command, particularly when it's invoked by make_release.

Evergreen 3.0+

Tags: cleanup
Changed in evergreen:
milestone: 3.0.1 → 3.0.2
Changed in evergreen:
milestone: 3.0.2 → 3.0.3
Changed in evergreen:
milestone: 3.0.3 → 3.0.4
Changed in evergreen:
milestone: 3.0.4 → 3.05
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Changed in evergreen:
milestone: 3.0.8 → 3.2-beta
Changed in evergreen:
milestone: 3.2-beta → 3.2-rc
Changed in evergreen:
milestone: 3.2-rc → 3.2.1
Changed in evergreen:
milestone: 3.2.1 → 3.2.2
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I've also had Node.JS suggest that I upgrade npm. After doing that recently, my build was broken. I do not recall the version number off the top of my head, but should be able to get it if necessary. We may want to assert maximum version numbers as well.

Now that we no longer support Debian Wheezy as an install target, the minimum version may be less of an issue.

Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
milestone: 3.2.3 → 3.2.4
Changed in evergreen:
milestone: 3.2.4 → 3.2.5
Elaine Hardy (ehardy)
tags: added: webstaffclient
Changed in evergreen:
milestone: 3.2.5 → 3.2.6
Changed in evergreen:
milestone: 3.2.6 → 3.2.7
Changed in evergreen:
milestone: 3.2.7 → none
tags: added: cleanup
removed: webstaffclient
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.