linux 4.13.0-13.14 ADT test failure with linux 4.13.0-13.14

[Seth Forshee]

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-bootstrap/artful/amd64/l/linux/20170930_151719_8c658@/log.gz
    i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-bootstrap/artful/i386/l/linux/20170930_220543_8c658@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-canonical-kernel-team-bootstrap/artful/ppc64el/l/linux/20170930_164802_8c658@/log.gz

[Seth Forshee (sforshee)]

Appears that kernel security tests need fixing after merging LSM stacking patches as config options have changed.

  ======================================================================
  FAIL: test_072_config_security_apparmor (__main__.KernelSecurityTest)
  CONFIG_SECURITY_APPARMOR enabled
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "./test-kernel-security.py", line 671, in test_072_config_security_apparmor
      self.assertEqual(self._get_config('DEFAULT_SECURITY_APPARMOR'), 'y')
  AssertionError: None != 'y'

  ----------------------------------------------------------------------

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1720660

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[John Johansen (jjohansen)]

Fixed in

commit 393d5cca6af1070709f2baaf291d16e27fbea366
Author: John Johansen <email address hidden>
Date: Thu Oct 5 13:50:51 2017 -0700

    Fix test-kernel-security.py when LSM stacking based kernel is used.

    In the LSM stacking kernel DEFAULT_SECURITY_APPARMOR is not set instead
    SECURITY_APPARMOR_STACKED is used to indicate it is part of the default
    stack.

    BugLink: http://bugs.launchpad.net/bugs/1720660
    Signed-off-by: John Johansen <email address hidden>

diff --git a/scripts/test-kernel-security.py b/scripts/test-kernel-security.py
index 2625f9aa..9eecdca5 100755
--- a/scripts/test-kernel-security.py
+++ b/scripts/test-kernel-security.py
@@ -668,7 +668,7 @@ class KernelSecurityTest(testlib.TestlibCase):
         '''CONFIG_SECURITY_APPARMOR enabled'''

         self.assertEqual(self._get_config('SECURITY_APPARMOR'), 'y')
- self.assertEqual(self._get_config('DEFAULT_SECURITY_APPARMOR'), 'y')
+ self.assertTrue(self._get_config('DEFAULT_SECURITY_APPARMOR') == 'y' or self._get_config('CONFIG_SECURITY_APPARMOR_STACKED') == 'y')
         self.assertEqual(self._get_config('SECURITY_APPARMOR_BOOTPARAM_VALUE'), '1')

     # Hardy and newer

[John Johansen (jjohansen)]

Marking it Fix Released. Please re-open if you find you still have issues.

[Seth Forshee (sforshee)]

Looks like there's a typo, s/assertEqaul/assertEqual/.

Traceback (most recent call last):
    File "./test-kernel-security.py", line 675, in test_072_config_security_apparmor
      self.assertEqaul(self._get_config(default_apparmor_option), 'y')
  AttributeError: 'KernelSecurityTest' object has no attribute 'assertEqaul'

[John Johansen (jjohansen)]

yep thanks, fixed and pushed