HIstory should not be editable

[Conner Phillips]

Currently the history "playlists" are just that. A largely unmodified subclass of a playlist. They are even stored in the playlist portion of the SQL database. The track position in the history view should not be modifiable. I don't know if this can be changed without creating a new table in the DB.

[Daniel Schürmann (daschuer)]

Yes right, the order should be fixed.
It should be still be possible to delete tracks. The use case is to clean up the history, before publishing.

I think a DB independent solution is possible.

[ronso0 (ronso0)]

Yes, please keep the possibility to delete tracks.
After a live session or recording it's useful to remove tracks -maybe from sound check or after hour- and have a clean playlist for publishing or just documentation.

[Conner Phillips (lindybalboa)]

I took a look at this. The problem stems from Playlists, AutoDJ, and History using the same playlisttablemodel.

A quick fix would be to change the getCapabilities function. Currently it is full of hardcoded constants. We could instead change it to read an object variable for this information. The object variable would need be set/adjusted and the time of object instantiation.

The other more extreme but flexible option is create an abstract version of the playlisttablemodel, and create subclasses for all 3 features.

Does anyone feel strongly about either implementation?

[Daniel Schürmann (daschuer)]

Why not just add

    if (m_pTrackCollection->getPlaylistDAO().getHiddenType(playlistId)
            == PlaylistDAO::PLHT_SET_LOG) {
         caps &= ~TRACKMODELCAPS_REORDER;
    }

to getCapabilities?

Otherwise I would prefer to inherit from playlisttablemodel and override getCapabilities()

[Conner Phillips (lindybalboa)]

IMO that first one is not transparent at all. I think a subclass is in order. Will try to get to it this week.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8946