juce_FlacAudioFormat.cpp tries to include wrong header (flac/all.h and following instead of FLAC/all.h or something)

Bug #1720634 reported by Dima
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juce (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

This bug (or not a bug) can be found in juce-modules-source package.
I've already installed libflac-dev package and it does not have any flac/all.h file. There is a FLAC/all.h only. And I've searched for flac/all.h by apt-file and did find nothing.
I think the problem is in this part of juce_FlacAudioFormat.cpp:

namespace FlacNamespace
{
#if JUCE_INCLUDE_FLAC_CODE || ! defined (JUCE_INCLUDE_FLAC_CODE)

[...]
 #undef __STDC_LIMIT_MACROS
 #define __STDC_LIMIT_MACROS 1
 #define flac_max jmax
 #define flac_min jmin
 #undef DEBUG // (some flac code dumps debug trace if the app defines this macro)
 #include "flac/all.h"
 #include "flac/libFLAC/bitmath.c"
 #include "flac/libFLAC/bitreader.c"
 #include "flac/libFLAC/bitwriter.c"
 #include "flac/libFLAC/cpu.c"
 #include "flac/libFLAC/crc.c"
 #include "flac/libFLAC/fixed.c"
 #include "flac/libFLAC/float.c"
 #include "flac/libFLAC/format.c"
 #include "flac/libFLAC/lpc_flac.c"
 #include "flac/libFLAC/md5.c"
 #include "flac/libFLAC/memory.c"
 #include "flac/libFLAC/stream_decoder.c"
 #include "flac/libFLAC/stream_encoder.c"
 #include "flac/libFLAC/stream_encoder_framing.c"
 #include "flac/libFLAC/window_flac.c"
 #undef VERSION
#else
 #include <FLAC/all.h>
#endif
[...]
}

1) Ubuntu Artful Aardvark (development branch) 17.10
2) juce-modules-source 4.3.0~repack-1
3) I expected this code will include FLAC/all.h or something.
4) It tries to include something that Ubuntu 17.10 does not have.

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: juce-modules-source 4.3.0~repack-1
ProcVersionSignature: Ubuntu 4.13.0-12.13-generic 4.13.3
Uname: Linux 4.13.0-12-generic x86_64
ApportVersion: 2.20.7-0ubuntu1
Architecture: amd64
CurrentDesktop: LXDE
Date: Sun Oct 1 15:22:41 2017
Dependencies:

InstallationDate: Installed on 2017-09-29 (1 days ago)
InstallationMedia: Lubuntu 17.10 "Artful Aardvark" - Alpha amd64 (20170926)
PackageArchitecture: all
SourcePackage: juce
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Dima (dima2017) wrote :
Revision history for this message
Dima (dima2017) wrote :

And yet another juce_OggVorbisAudioFormat.cpp tries to include oggvorbis/vorbisenc.h

Revision history for this message
Dima (dima2017) wrote :

And juce_GZIPDecompressorInputStream.cpp tries to include zlib/zlib.h instead of zlib.h

Revision history for this message
Dima (dima2017) wrote :

This errors occurs when I tried to compile this https://github.com/EVERTims/auralization_engine_evertims

Version of juce modules 5.2.1, which I got from this page https://www.juce.com/get-juce/download compiles without errors.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juce - 5.2.0~repack-2

---------------
juce (5.2.0~repack-2) unstable; urgency=medium

  * Projucer: use Debian's JUCE modules by default
  * modules-sources: force system provided use of libflac and libvorbis
    (LP: #1720634)
  * Recommend image/audio format libraries and depend on zlib-dev
  * Fixed formatting of NEWS file

 -- IOhannes m zmölnig (Debian/GNU) <email address hidden> Tue, 19 Dec 2017 11:43:22 +0100

Changed in juce (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.