test_list_get_volume_attachments calling detach volume twice but failed to receive the right exception in the second call

[Guy]

In this test, we attach the volume to an instance and detach it after.
There are two calls of detaching the volume:
- first call is done by the test (https://github.com/openstack/tempest/blob/master/tempest/api/compute/volumes/test_attach_volume.py#L146)
- second call is done by a cleanup at the end of the tests ( self.addCleanup(test_utils.call_and_ignore_notfound_exc,
)

The first call for detaching the volume is a success. But the second call returns this error: "{"badRequest": {"message": "Invalid volume: Invalid input received: Invalid volume: Unable to detach volume. Volume status must be 'in-use' and attach_status must be 'attached' to detach. (HTTP 400) (Request-ID: req-f7a17aff-cbed-4203-a6a1-65635a39b878)", "code": 400}}"

We hit the issue in our third party CI running for Cinder.

The second call will call the method "call_ignore_not_found_exc" (https://github.com/openstack/tempest/blob/master/tempest/lib/common/utils/test_utils.py#L81). If it receives a "NotFound" exception from the rest client, the second call for detaching the volume is skipped.

In our CI, it doesn't receive this exception because the rest client raises BadRequest exception (400) instead of NotFound (404).

The complete logs of the tests can be found here (http://188.166.245.68/67/504467/5/check/dsvm-tempest-ITRI-DISCO-cinder-driver/c0a5799//logs/testr_results.html.gz)

[Ghanshyam Mann (ghanshyammann)]

fix is up for this- https://review.openstack.org/#/c/510951/

[Guy (guy-kim088)]

Ok thank you for the link of the fix. I close this bug since it is a duplicated one.