Debug paramter using wrong type
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
oslo.config |
Won't Fix
|
Undecided
|
Unassigned | ||
puppet-oslo |
Fix Released
|
Medium
|
Alex Schultz | ||
tripleo |
Fix Released
|
High
|
Ade Lee |
Bug Description
The Debug heat parameter is used in many services templates to set whether logging should be verbose or not. It is currently of type string and defaults to an empty string ('').
This works for several services (such as keystone), since the historical debug option was moved to the logging resource, and the original value (which we set in tripleo) is ignored thanks to the pick function:
https:/
This, however, breaks for services that use the value as-is. such as barbican:
https:/
Since it ends up with an invalid value in oslo.log
debug=
that, if we try to use it, breaks the service:
[Fri Sep 22 21:49:09.233707 2017] [:error] [pid 19] argument --debug: Invalid Boolean value:
[Fri Sep 22 21:49:09.233912 2017] [:error] [pid 19] [remote 172.16.2.7:164] mod_wsgi (pid=19): Target WSGI script '/v
ar/www/
[Fri Sep 22 21:49:09.233942 2017] [:error] [pid 19] [remote 172.16.2.7:164] mod_wsgi (pid=19): SystemExit exception r
aised by WSGI script '/var/www/
[Fri Sep 22 21:49:09.233972 2017] [:error] [pid 19] [remote 172.16.2.7:164] Traceback (most recent call last):
[Fri Sep 22 21:49:09.233996 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/var/www/
line 24, in <module>
[Fri Sep 22 21:49:09.234101 2017] [:error] [pid 19] [remote 172.16.2.7:164] from barbican.api import app
[Fri Sep 22 21:49:09.234116 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
barbican/
[Fri Sep 22 21:49:09.234251 2017] [:error] [pid 19] [remote 172.16.2.7:164] from barbican.common import config
[Fri Sep 22 21:49:09.234270 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
barbican/
[Fri Sep 22 21:49:09.234507 2017] [:error] [pid 19] [remote 172.16.2.7:164] parse_args(CONF)
[Fri Sep 22 21:49:09.234524 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
barbican/
[Fri Sep 22 21:49:09.234550 2017] [:error] [pid 19] [remote 172.16.2.7:164] default_
iles)
[Fri Sep 22 21:49:09.234559 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
oslo_config/
[Fri Sep 22 21:49:09.235776 2017] [:error] [pid 19] [remote 172.16.2.7:164] else sys.argv[1:])
[Fri Sep 22 21:49:09.235798 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
oslo_config/
[Fri Sep 22 21:49:09.235823 2017] [:error] [pid 19] [remote 172.16.2.7:164] return self._parse_
[Fri Sep 22 21:49:09.235832 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
oslo_config/
[Fri Sep 22 21:49:09.235846 2017] [:error] [pid 19] [remote 172.16.2.7:164] self._validate_
[Fri Sep 22 21:49:09.235853 2017] [:error] [pid 19] [remote 172.16.2.7:164] File "/usr/lib/
oslo_config/
[Fri Sep 22 21:49:09.235866 2017] [:error] [pid 19] [remote 172.16.2.7:164] raise SystemExit
[Fri Sep 22 21:49:09.235889 2017] [:error] [pid 19] [remote 172.16.2.7:164] SystemExit
This seems to be an error on two fronts:
* We should pass a value of the correct type in tripleo-
* We should validate the value correct in puppet-oslo.
Changed in tripleo: | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Ade Lee (alee-3) |
Changed in puppet-oslo: | |
importance: | Undecided → Medium |
Changed in tripleo: | |
milestone: | none → queens-1 |
I added oslo.log because I believe it shouldn't error on debug=. There is an issue with puppet-oslo not handling '' correctly but there's a few different things wrong with this