never add/remove tenant access for nova flavor resource

[huangtianhua]

For nova flavor resource, if the property 'is_public' set to false, we are going to add tenant access, but the code is incorrect, we don't check the value of property 'is_public', instead we check the property name:
        if not self.IS_PUBLIC:
            if not tenants:
                LOG.info('Tenant property is recommended if IS_PUBLIC '
                         'is false.')
                tenant = self.stack.context.tenant_id
                self.client().flavor_access.add_tenant_access(flavor, tenant)
            else:
                for tenant in tenants:
                    # grant access only to the active project(private flavor)
                    self.client().flavor_access.add_tenant_access(flavor,
                                                                  tenant)

We have the same problem when update the flavor.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/507792

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507792
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=13cd27a955a28720422141355ec5b255721dd301
Submitter: Jenkins
Branch: master

commit 13cd27a955a28720422141355ec5b255721dd301
Author: huangtianhua <email address hidden>
Date: Wed Sep 27 16:47:26 2017 +0800

    Make private flavor tenant access works

    Make private flavor tenant access works.

    Change-Id: Ibcb82d3518320534e9e0397e9d0651c3b602d439
    Closes-Bug: #1719805

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/510388

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510388
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=17eb45b4218d29f93b0060ce895d80e47d3ca8bf
Submitter: Jenkins
Branch: stable/pike

commit 17eb45b4218d29f93b0060ce895d80e47d3ca8bf
Author: huangtianhua <email address hidden>
Date: Wed Sep 27 16:47:26 2017 +0800

    Make private flavor tenant access works

    Make private flavor tenant access works.

    Change-Id: Ibcb82d3518320534e9e0397e9d0651c3b602d439
    Closes-Bug: #1719805
    (cherry picked from commit 13cd27a955a28720422141355ec5b255721dd301)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 10.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.1 release.