Ocata to Pike upgrade broken by host_prep_tasks running on non controllers during controlplane upgrade

[Marios Andreou]

As discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1494107 during the Ocata to Pike controlplane upgrade (i.e. -e major-upgrade-composable-steps-docker.yaml) the nova-libvirt service manifest has a host_prep_tasks ansible task here https://github.com/openstack/tripleo-heat-templates/blob/420126fd98193f755562887603f604ca5fd53175/docker/services/nova-libvirt.yaml#L288-L295 which stops the libvirtd service, on the *compute* nodes as well.

It should not be running on the 'non controllers' (those nodes that have the disable_upgrade_deployment flag set to true in roles_data.yaml) at this stage as those will be upgraded later. The role specific host_prep_tasks will be executed then as they are included in the deploy_steps_playbook https://github.com/openstack/tripleo-heat-templates/blob/3dcc9b30e9991087b9e898e25685985df6f94361/common/deploy-steps.j2#L324-L372

For O..P non controllers are upgraded using the upgrade-non-controller.sh here https://github.com/openstack/tripleo-common/blob/b46a35a40e69ae639d2bff680eeb2c5e01898054/scripts/upgrade-non-controller.sh#L139-L147

[Marios Andreou (marios-b)]

16:13 #tripleo: < openstackgerrit> Marios Andreou proposed openstack/tripleo-heat-templates master: Disable role host_prep_tasks on controlplane upgrade https://review.openstack.org/507524

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507524
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=684267a7a4fbff489f6324020289afbdcaaca8f5
Submitter: Jenkins
Branch: master

commit 684267a7a4fbff489f6324020289afbdcaaca8f5
Author: marios <email address hidden>
Date: Tue Sep 26 15:33:13 2017 +0300

    Disable role host_prep_tasks on controlplane upgrade

    During the controlplane upgrade the host_prep_tasks are being
    executed on the disable_upgrade_deployment roles too.

    This sets the role specific host_prep_tasks to an empty list for
    those roles during an upgrade, as executing them during the
    controlplane upgrade (during -e
    major-upgrade-composable-steps-docker.yaml) causes problems.

    They will be executed as part of the non controller upgrade as they
    are written to the stack outputs to be used as ansible playbooks
    (see bug 1708115 for more info on this)

    Change-Id: I42c963440b9b1e8222097c3d4e83ffcbe820886c
    Closes-Bug: 1719604

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/509345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/509345
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a2ab21881c4b2a61cb09b48cf8ffe12600042338
Submitter: Jenkins
Branch: stable/pike

commit a2ab21881c4b2a61cb09b48cf8ffe12600042338
Author: marios <email address hidden>
Date: Tue Sep 26 15:33:13 2017 +0300

    Disable role host_prep_tasks on controlplane upgrade

    During the controlplane upgrade the host_prep_tasks are being
    executed on the disable_upgrade_deployment roles too.

    This sets the role specific host_prep_tasks to an empty list for
    those roles during an upgrade, as executing them during the
    controlplane upgrade (during -e
    major-upgrade-composable-steps-docker.yaml) causes problems.

    They will be executed as part of the non controller upgrade as they
    are written to the stack outputs to be used as ansible playbooks
    (see bug 1708115 for more info on this)

    Change-Id: I42c963440b9b1e8222097c3d4e83ffcbe820886c
    Closes-Bug: 1719604
    (cherry picked from commit 684267a7a4fbff489f6324020289afbdcaaca8f5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.