elementary os-release ID crashes snapcraft

[Cody Garver]

The ID in the content of /etc/os-release crashes snapcraft:

NAME="elementary OS"
VERSION="0.4.1 Loki"
ID="elementary"
ID_LIKE=ubuntu
PRETTY_NAME="elementary OS 0.4.1 Loki"
VERSION_ID="0.4.1"
HOME_URL="http://elementary.io/"
SUPPORT_URL="http://elementary.io/support/"
BUG_REPORT_URL="https://github.com/elementary/"
VERSION_CODENAME=loki
UBUNTU_CODENAME=loki

[Zygmunt Krynicki (zyga)]

The ID is invalid according to the specification in os-release(5)

To quote the manual page:

       ID=
           A lower-case string (no spaces or other characters outside of 0–9,
           a–z, ".", "_" and "-") identifying the operating system, excluding
           any version information and suitable for processing by scripts or
           usage in generated filenames. If not set, defaults to "ID=linux".
           Example: "ID=fedora" or "ID=debian".

You cannot use spaces in this field.

[Cody Garver (codygarver)]

Sorry, I pasted the os-release that actually works. WITHOUT the space it crashes.

The backstory is it was invalid originally, you guys fixed it on your end and informed us it was invalid. So we changed it to become valid and that broke your fix.

Sorry for the confusion, I will update the bug.

[Kyle Fazzari (kyrofa)]

Quick fix here: https://github.com/snapcore/snapcraft/pull/1637