pacemaker remote errors with 'Illegal relationship operand....'

[Michele Baldessari]

Sasha showed me an environment where the Networker role was populated with:
  ServicesDefault:
    - OS::TripleO::Services::AuditD
    - OS::TripleO::Services::CACerts
    - OS::TripleO::Services::CertmongerUser
    - OS::TripleO::Services::Collectd
    - OS::TripleO::Services::Docker
    - OS::TripleO::Services::FluentdClient
    - OS::TripleO::Services::Kernel
    - OS::TripleO::Services::MySQLClient
    - OS::TripleO::Services::NeutronApi
    - OS::TripleO::Services::NeutronBgpVpnApi
    - OS::TripleO::Services::NeutronCorePlugin
    - OS::TripleO::Services::NeutronDhcpAgent
    - OS::TripleO::Services::NeutronL2gwAgent
    - OS::TripleO::Services::NeutronL2gwApi
    - OS::TripleO::Services::NeutronL3Agent
    - OS::TripleO::Services::NeutronLbaasv2Agent
    - OS::TripleO::Services::NeutronMetadataAgent
    - OS::TripleO::Services::NeutronML2FujitsuCfab
    - OS::TripleO::Services::NeutronML2FujitsuFossw
    - OS::TripleO::Services::NeutronOvsAgent
    - OS::TripleO::Services::NeutronVppAgent
    - OS::TripleO::Services::Ntp
    - OS::TripleO::Services::ContainersLogrotateCrond
    - OS::TripleO::Services::OpenDaylightOvs
    - OS::TripleO::Services::PacemakerRemote
    - OS::TripleO::Services::SensuClient
    - OS::TripleO::Services::Snmp
    - OS::TripleO::Services::Timezone
    - OS::TripleO::Services::TripleoFirewall
    - OS::TripleO::Services::TripleoPackages
    - OS::TripleO::Services::Tuned

And it broke with:
Error: Evaluation Error: Illegal relationship operand, can not form a relationship with an Undef Value. A Catalog type is required. at /etc/puppet/modules/pacemaker/manifests/remote.pp:31:6 on node

The reason is that the change introduced in https://review.openstack.org/#/c/503077/ broke the pacemaker remote functionality.

[Michele Baldessari (michele)]

https://review.openstack.org/505813

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/505813
Committed: https://git.openstack.org/cgit/openstack/puppet-pacemaker/commit/?id=d952513d4180705002dae9901db3af00cfb4f05a
Submitter: Jenkins
Branch: master

commit d952513d4180705002dae9901db3af00cfb4f05a
Author: Michele Baldessari <email address hidden>
Date: Wed Sep 20 22:57:57 2017 +0200

    Fix pacemaker remote 'Illegal relationship operand..' errors

    Trying to use a pacemaker remote manifest breaks like this:

    Error: Evaluation Error: Illegal relationship operand, can not form a
    relationship with an Undef Value. A Catalog type is required. at
    /etc/puppet/modules/pacemaker/manifests/remote.pp:31:6 on node

    The reason is that the change introduced in
    I9511c1830b967038721e03dcbb4401cc3059648a broke the pacemaker remote
    functionality.

    Let's switch to resource collectors to fix these relationship
    issues so we still get the ordering right without the issue:
    Debug: /Stage[main]/Pacemaker::Remote/Package[pacemaker-remote]/before: subscribes to File[etc-pacemaker]

    Closes-Bug: #1718534

    Change-Id: I0b1a5821226491a453b816e3b09369dc4b60d31b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-pacemaker 0.7.0 release.