[4.1.0.0-47] BFD packets sent even after disassociating Health Check from BGPaaS

[Ganesha HV]

Setup
=====
controller - nodeg25, g26, g27.
computes - nodek8, k9, k10.
Horizon/UI - nodeg25.

Steps
=====
1]. Created a BGPaaS and attached it to VMI with IP 10.10.10.5.
2]. On the vSRX with IP 10.10.10.5, created a eBGP session between lo0.0(10.10.10.100) and 10.10.10.1 and 10.10.10.2
3]. Enabled BFD on the BGP session:

[edit]
root# run show bgp summary
Groups: 1 Peers: 2 Down peers: 0
Table Tot Paths Act Paths Suppressed History Damp State Pending
inet.0 10 2 0 0 0 0
inet6.0 0 0 0 0 0 0
Peer AS InPkt OutPkt OutQ Flaps Last Up/Dwn State|#Active/Received/Accepted/Damped...
10.10.10.1 64512 2435 2695 0 0 20:14:06 Establ
  inet.0: 2/5/5/0
  inet6.0: 0/0/0/0
10.10.10.2 64512 2435 2694 0 0 20:14:02 Establ
  inet.0: 0/5/5/0
  inet6.0: 0/0/0/0

[edit]

[edit]
root# run show bfd session
                                                  Detect Transmit
Address State Interface Time Interval Multiplier
10.10.10.1 Up 3.000 1.000 3
10.10.10.2 Up 3.000 1.000 3

2 sessions, 2 clients
Cumulative transmit rate 2.0 pps, cumulative receive rate 2.0 pps

[edit]

4]. Created a HC, with the following parameters and attached it to BGPaaS.

service_health_check_properties: {
timeout: 1
timeoutUsecs: 0
enabled: true
delay: 1
expected_codes: null
max_retries: 3
http_method: null
delayUsecs: 0
url_path: "10.10.10.100"
monitor_type: "BFD"
health_check_type: "link-local"
}
name: "bgp1"

5]. After disassociating the HC from the BGPaaS, BFD packets are exchanged between 10.10.10.1>10.10.10.100 and 10.10.10.2>10.10.10.100:

07:12:57.753459 Out 02:f8:b0:b7:47:d9 > 00:00:5e:00:01:00, ethertype IPv4 (0x0800), length 66: 10.10.10.100.49152 > 10.10.10.2.4784: BFDv1, Multi-hop Control, State Up, Flags: [none], length: 24
07:12:57.897472 In PFE proto 2 (ipv4): 10.10.10.2.52667 > 10.10.10.100.4784: BFDv1, Multi-hop Control, State Up, Flags: [none], length: 24
07:12:58.349597 In PFE proto 2 (ipv4): 10.10.10.1.56432 > 10.10.10.100.4784: BFDv1, Multi-hop Control, State Up, Flags: [none], length: 24
07:12:58.355377 Out 02:f8:b0:b7:47:d9 > 00:00:5e:00:01:00, ethertype IPv4 (0x0800), length 66: 10.10.10.100.49152 > 10.10.10.1.4784: BFDv1, Multi-hop Control, State Up, Flags: [none], length: 24

[Ganesha HV (ganeshahv)]

Even when the associated Health-Check protocol is changed to PING/HTTP, E2E or Link-local, there is no change. Only BFD packets are sent.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37190
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/37191
Submitter: Hari Prasad Killi (<email address hidden>)

[Hari Prasad Killi (haripk)]

The original problem reported is also addressed with the fix for https://bugs.launchpad.net/juniperopenstack/+bug/1721507.

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37190
Committed: http://github.com/Juniper/contrail-controller/commit/2a3d4567d74d128cddc93090691c9028cac19c60
Submitter: Zuul (<email address hidden>)
Branch: master

commit 2a3d4567d74d128cddc93090691c9028cac19c60
Author: Hari Prasad Killi <email address hidden>
Date: Mon Nov 6 15:57:16 2017 +0530

Re-evaluate BGPaaS config when there is change in HC config

If HC changes from BFD to other type or vice versa, need to re-evaluate
BGPaaS, updte dependency manager rule accordingly. Also, trigger delete
of any older instances.

Change-Id: I94dc9506ec4184389f61579ab36308e505655f56
partial-bug: #1718359

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/37191
Committed: http://github.com/Juniper/contrail-controller/commit/a46c0f5388f8191088e92a47cc9d42c1566b8235
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit a46c0f5388f8191088e92a47cc9d42c1566b8235
Author: Hari Prasad Killi <email address hidden>
Date: Mon Nov 6 15:57:16 2017 +0530

Re-evaluate BGPaaS config when there is change in HC config

If HC changes from BFD to other type or vice versa, need to re-evaluate
BGPaaS, updte dependency manager rule accordingly. Also, trigger delete
of any older instances.

Change-Id: I94dc9506ec4184389f61579ab36308e505655f56
partial-bug: #1718359