pxc should block when VIP is set and hacluster is present

[Ryan Beisner]

pxc should block when VIP is set and hacluster is present

It is possible for percona-cluster to reach a clustered/ready state and begin establishing relations with other applications before hacluster is clustered and ready. This can cause other applications to execute extra and unnecessary hook operations.

When percona-cluster is used with hacluster, a VIP charm config is set. That can be used to know when to wait for hacluster readiness in this case.

[David Ames (thedac)]

Confirmed cluster_ready is checking the 'cluster' relation and does nothing to check the 'ha' (hacluster) relation.

Suggest we react to hacluster's clustered='yes' in the primary charm.
https://github.com/openstack/charm-hacluster/blob/master/hooks/hooks.py#L401

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/506276

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/506276
Committed: https://git.openstack.org/cgit/openstack/charm-percona-cluster/commit/?id=ce78dd4dcf1d25e808d4ac302f82102f83d4f159
Submitter: Jenkins
Branch: master

commit ce78dd4dcf1d25e808d4ac302f82102f83d4f159
Author: David Ames <email address hidden>
Date: Thu Sep 21 16:09:35 2017 +0000

    When VIP is set wait on hacluster is_clustered

    Delay serving client relations until hacluster signals its readiness
    when VIP is set.

    Change-Id: I7dce1dd3d6891ff7fc4c6cc32d3d7ebc6c268c82
    Closes-Bug: #1718247

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/17.08
Review: https://review.openstack.org/507554

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507554
Committed: https://git.openstack.org/cgit/openstack/charm-percona-cluster/commit/?id=b88c281ea7c1a432f2c08625bb02dc8e049c6f45
Submitter: Jenkins
Branch: stable/17.08

commit b88c281ea7c1a432f2c08625bb02dc8e049c6f45
Author: David Ames <email address hidden>
Date: Thu Sep 21 16:09:35 2017 +0000

    When VIP is set wait on hacluster is_clustered

    Delay serving client relations until hacluster signals its readiness
    when VIP is set.

    Change-Id: I7dce1dd3d6891ff7fc4c6cc32d3d7ebc6c268c82
    Closes-Bug: #1718247
    (cherry picked from commit ce78dd4dcf1d25e808d4ac302f82102f83d4f159)