web client: better label for 'publicly visible' buckets

Bug #1717996 reported by Kathy Lussier
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.4
Fix Released
Undecided
Unassigned

Bug Description

In the web client, there is a new option for copy and record buckets to make them 'publicly visible'.

The 'publicly visible?' flag allows staff that do not have VIEW_CONTAINER permissions at the right depth to view the bucket. However, a staff login is required to view the bucket, so the bucket isn't really visible to the public.

I think the label should be changed so that it doesn't give the impression that the bucket can be shared with the public at large.

'Shared?' might work, but others may have a better idea.

Revision history for this message
Kathy Lussier (klussier) wrote :

I noticed that patron buckets say 'staff sharable.' This is better than publicly visible. I still prefer "Shared", but if we keep it as staff sharable, we should probably spell it as shareable. http://grammarist.com/spelling/sharable-shareable/

Revision history for this message
Mike Rylander (mrylander) wrote :

FWIW, the "pub" bool column on record and copy buckets allows them to be used in searches, as well as to be shared between staff. Perhaps "Shareable" without "Staff" is best? I'm OK with "Shared" if that's the consensus, but that suggests that they are directly accessible through some list interface, which isn't true today except by the owner.

Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Elizabeth Thomsen (et-8) wrote :

Just agreeing that this should be changed to Shareable (with or without the word staff.) Publicly visible implies that this turns the bucket into a bookbag, which would be cool, but isn't what happens here. The priority is low because it doesn't affect functionality, but unclear wording like this requires repeated clarification.

Kathy Lussier (klussier)
Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
Revision history for this message
Elaine Hardy (ehardy) wrote :

+1 for Shareable

Changed in evergreen:
assignee: nobody → Tiffany Little (tslittle)
Revision history for this message
Jennifer Weston (jweston) wrote :

+1 for Shareable

tags: added: buckets
Revision history for this message
Tiffany Little (tslittle) wrote :

Patch for review here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=69326fa9aabddb2738e64f514bf59990e2bed304

I also added a tooltip next to it to expand on what 'shareable' actually means for these buckets.

tags: added: pullrequest
Changed in evergreen:
assignee: Tiffany Little (tslittle) → nobody
Dan Pearl (dpearl)
Changed in evergreen:
assignee: nobody → Dan Pearl (dpearl)
Revision history for this message
Dan Pearl (dpearl) wrote :

Works as intended.

user/dpearl/LP1717996_change_bucket_label-signoff

tags: added: signedoff
Changed in evergreen:
assignee: Dan Pearl (dpearl) → nobody
Revision history for this message
Jane Sandberg (sandbergja) wrote :

This looks good -- thanks, Tiffany and Dan.

I do have two suggestions, though, before this gets merged:

1) Currently, when you click on the question mark to get more information, it also checks the checkbox. Users should be able to learn about Shareable buckets without Evergreen checking that box for them. To do this, the <eg-help-popover> tag should be outside the <label> tag.

2) The <eg-help-popover> line should match the indentation conventions of the rest of the file.

Revision history for this message
Tiffany Little (tslittle) wrote :
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Works well for me, Tiffany. Sign off branch here: user/sandbergja/lp1717996_bucketsvisiblelabel_signoff

Here's a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1717996_bucketsvisiblelabel_signoff

I also snuck in a follow-up commit to that branch, which applies Tiffany's change to the user buckets too.

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.5-alpha
Changed in evergreen:
status: New → Confirmed
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: 3.5-beta → 3.5.0
Changed in evergreen:
milestone: 3.5.0 → 3.5.1
Jason Boyer (jboyer)
Changed in evergreen:
assignee: nobody → Jason Boyer (jboyer)
Revision history for this message
Jason Boyer (jboyer) wrote :

Pushed to master, rel_3_5, and rel_3_4 along with a little nudge to realign the tag layout. Thanks Tiffany and Jane!

Changed in evergreen:
assignee: Jason Boyer (jboyer) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.