Failed to run Controller node tests (ifmap and bgp)

[Édouard Thuleau]

On Ubuntu 16.04.4 with GCC 5.4.0 and libboost 1.61, when I'm trying to run controller tests (src/ifmap or src/bgp), lot of them failed to compile:

controller/src/bgp/test/path_resolver_test.cc: In instantiation of ‘void PathResolverTest_MultiplePrefixChangeXmppPath1_Test<gtest_TypeParam_>::TestBody() [with gtest_TypeParam_ = TypeDefinition<InetTable,
 Ip4Prefix>]’:
/usr/include/boost/program_options/variables_map.hpp:146:38: required from here
controller/src/base/test/task_test_util.h:137:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if ((expected) == (actual)) { \
                        ^
controller/src/base/test/task_test_util.h:344:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/path_resolver_test.cc:2136:5: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
     TASK_UTIL_EXPECT_EQ(DB::PartitionCount() * 2,
     ^
controller/src/base/test/task_test_util.h:144:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if ((expected) == (actual)) { \
                        ^
controller/src/base/test/task_test_util.h:344:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/path_resolver_test.cc:2136:5: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
     TASK_UTIL_EXPECT_EQ(DB::PartitionCount() * 2,
     ^
controller/src/base/test/task_test_util.h:153:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if((expected) != (actual)) \
                       ^
controller/src/base/test/task_test_util.h:344:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/path_resolver_test.cc:2136:5: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
     TASK_UTIL_EXPECT_EQ(DB::PartitionCount() * 2,
     ^
controller/src/base/test/task_test_util.h:137:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if ((expected) == (actual)) { \
                        ^
controller/src/base/test/task_test_util.h:344:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/path_resolver_test.cc:2146:5: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
     TASK_UTIL_EXPECT_EQ(DB::PartitionCount() * 2,
     ^
controller/src/base/test/task_test_util.h:144:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if ((expected) == (actual)) { \
                        ^
controller/src/base/test/task_test_util.h:344:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/path_resolver_test.cc:2146:5: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
     TASK_UTIL_EXPECT_EQ(DB::PartitionCount() * 2,
     ^
controller/src/base/test/task_test_util.h:153:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
         if((expected) != (actual)) \
                       ^
controller/src/base/test/task_test_util.h:344:5: note: in expansion of macro ‘TASK_UTIL_WAIT_EQ’
     TASK_UTIL_WAIT_EQ(expected, actual, task_util_wait_time(), \
     ^
controller/src/bgp/test/path_resolver_test.cc:2146:5: note: in expansion of macro ‘TASK_UTIL_EXPECT_EQ’
     TASK_UTIL_EXPECT_EQ(DB::PartitionCount() * 2,

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35633
Submitter: ?douard Thuleau (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/35633
Committed: http://github.com/Juniper/contrail-controller/commit/bf70cee5db75951f966aebf8335b5eb914ef3f6b
Submitter: Zuul (<email address hidden>)
Branch: master

commit bf70cee5db75951f966aebf8335b5eb914ef3f6b
Author: Édouard Thuleau <email address hidden>
Date: Fri Sep 15 09:32:39 2017 +0200

Fix compilation issue with GCC 5.4.0

Change-Id: Ia61218ec5254c575b9ce60e67fd07f61d1b6e638
Closes-Bug: #1717445