ubuntu-cpc lacks common function to reverse setup_mountpoint
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
livecd-rootfs (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Zesty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[SRU Justification]
After the move of livefs builds to lxd containers and use of --rbind with /dev, cloud image builds fail where setup_mountpoint was called from the common functions. There is no related teardown for this common function so extra binary hooks that called setup_mountpoint were forced to duplicate the cleanup locally which became out of sync with the setup.
This change adds a common function called teardown_mountpoint to reverse the operations performed by setup_mountpoint and makes use of that new function.
[Test case]
Daily images on cloud-images.
We will verify this fix by verifying that we are able to produce daily cloud images again for each of the releases.
[Regression potential]
For xenial we should also verify this change by doing a test build of all images against xenial-proposed to guard against any possible regressions.
For zesty, there are no ongoing builds of any projects other than cloud images so there is no risk of external regressions.
Related branches
- Ubuntu Core Development Team: Pending requested
-
Diff: 77 lines (+27/-13)3 files modifieddebian/changelog (+12/-0)
live-build/functions (+14/-8)
live-build/ubuntu-cpc/hooks/032-root-squashfs.binary (+1/-5)
description: | updated |
Changed in livecd-rootfs (Ubuntu): | |
status: | New → Fix Committed |
tags: | added: id-5a0c4f9ba15e92a464ef41c2 |
Attaching a patch to add a teardown_mountpoint function to reverse the actions taken by setup_mountpoint.