SI not deleted upon lbaas delete

[Senthilnathan Murugappan]

version: 4.1.0.0-50~newton
Cluster: 10.87.118.171 has screen test (escape char tick ` )
testcase: scripts.lbaasv2.test_lbaasv2.TestLBaaSV2.test_lbaas_with_different_fip

Seems https://review.opencontrail.org/#/c/35218/ alone doesn't resolve the stale SI issue.

root@server1:~# neutron lbaas-loadbalancer-list

root@server1:~# neutron lbaas-listener-list

root@server6(controller):/# curl -uadmin:c0ntrail123 http://127.0.0.1:8095/service-instance/73e79e6b-3625-40f1-8303-2fb2fcbf3274 | python -mjson.tool
{
    "service-instance": {
        "display_name": "b29ef85a-6c42-4379-bab1-de5684a0726c",
        "fq_name": [
            "default-domain",
            "ctest-TestLBaaSV2-70074392",
            "b29ef85a-6c42-4379-bab1-de5684a0726c"
        ],
        "href": "http://127.0.0.1:8095/service-instance/73e79e6b-3625-40f1-8303-2fb2fcbf3274",
        "id_perms": {
            "created": "2017-09-12T12:04:43.427677",
            "creator": null,
            "description": null,
            "enable": true,
            "last_modified": "2017-09-12T12:12:23.687209",
            "permissions": {
                "group": "admin",
                "group_access": 7,
                "other_access": 7,
                "owner": "admin",
                "owner_access": 7
            },
            "user_visible": true,
            "uuid": {
                "uuid_lslong": 9440441689689764468,
                "uuid_mslong": 8351818217288974577
            }
        },
        "name": "b29ef85a-6c42-4379-bab1-de5684a0726c",
        "parent_href": "http://127.0.0.1:8095/project/f632e9a3-c766-4767-8d81-d6fe4dbabd79",
        "parent_type": "project",
        "parent_uuid": "f632e9a3-c766-4767-8d81-d6fe4dbabd79",
        "perms2": {
            "global_access": 0,
            "owner": "f632e9a3c76647678d81d6fe4dbabd79",
            "owner_access": 7,
            "share": []
        },
        "service_instance_bindings": {
            "key_value_pair": [
                {
                    "key": "lb_version",
                    "value": "v2"
                },
                {
                    "key": "lb_uuid",
                    "value": "b29ef85a-6c42-4379-bab1-de5684a0726c"
                },
                {
                    "key": "haproxy_config",
                    "value": "global\n\tdaemon\n\tuser haproxy\n\tgroup haproxy\n\tlog /dev/log local0\n\tlog /dev/log local1 notice\n\ttune.ssl.default-dh-param 2048\n\tssl-default-bind-ciphers ECDH+AESGCM:DH+AESGCM:ECDH+AES256:DH+AES256:ECDH+AES128:DH+AES:ECDH+3DES:DH+3DES:RSA+AESGCM:RSA+AES:RSA+3DES:!aNULL:!MD5:!DSS\n\tulimit-n 200000\n\tmaxconn 65000\n\tstats socket /var/lib/contrail/loadbalancer/haproxy/b29ef85a-6c42-4379-bab1-de5684a0726c/haproxy.sock mode 0666 level user\n\ndefaults\n\tlog global\n\tretries 3\n\toption redispatch\n\ttimeout connect 5000\n\ttimeout client 300000\n\ttimeout server 300000\n\n\n"
                }
            ]
        },
        "service_instance_properties": {
            "auto_policy": false,
            "availability_zone": null,
            "ha_mode": "active-standby",
            "interface_list": [
                {
                    "allowed_address_pairs": null,
                    "ip_address": "151.13.1.6",
                    "static_routes": null,
                    "virtual_network": "default-domain:ctest-TestLBaaSV2-70074392:ctest-vn-70524873"
                }
            ],
            "left_ip_address": null,
            "left_virtual_network": null,
            "management_virtual_network": null,
            "right_ip_address": null,
            "right_virtual_network": null,
            "scale_out": {
                "auto_scale": false,
                "max_instances": 2
            },
            "virtual_router_id": null
        },
        "service_template_refs": [
            {
                "attr": null,
                "href": "http://127.0.0.1:8095/service-template/5e943f23-6d90-44f0-a234-eac4438036d4",
                "to": [
                    "default-domain",
                    "haproxy-loadbalancer-template"
                ],
                "uuid": "5e943f23-6d90-44f0-a234-eac4438036d4"
            }
        ],
        "uuid": "73e79e6b-3625-40f1-8303-2fb2fcbf3274",
        "virtual_machine_back_refs": [
            {
                "attr": null,
                "href": "http://127.0.0.1:8095/virtual-machine/9e68642b-048e-4750-936a-3db98bb32995",
                "to": [
                    "default-domain__ctest-TestLBaaSV2-70074392__b29ef85a-6c42-4379-bab1-de5684a0726c__1"
                ],
                "uuid": "9e68642b-048e-4750-936a-3db98bb32995"
            },
            {
                "attr": null,
                "href": "http://127.0.0.1:8095/virtual-machine/0dd903ce-29e4-42f7-b40f-7055affc6502",
                "to": [
                    "default-domain__ctest-TestLBaaSV2-70074392__b29ef85a-6c42-4379-bab1-de5684a0726c__2"
                ],
                "uuid": "0dd903ce-29e4-42f7-b40f-7055affc6502"
            }
        ]
    }
}

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35596
Submitter: Yuvaraja Mariappan

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/35596
Committed: http://github.com/Juniper/contrail-controller/commit/97482b3c7097c0440510635d3258103c82e6f717
Submitter: Zuul (<email address hidden>)
Branch: master

commit 97482b3c7097c0440510635d3258103c82e6f717
Author: Yuvaraja Mariappan <email address hidden>
Date: Wed Sep 13 15:59:56 2017 -0700

Fixed service-instance delete issue

During the loadbalancer delete, If the instance ip
is removed before the service instance, the evalute of
service instance would call the create_service_instance()
which would do the chown for the instance_ip which may not
be there which would cause this error.
Added exception handler to handle this.

Change-Id: I7688b8818f4b68c117ebc024d192fa3f2b4454fb
Closes-bug: #1716881

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35617
Submitter: Yuvaraja Mariappan

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35687
Submitter: Yuvaraja Mariappan

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/35701
Submitter: Yuvaraja Mariappan

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/35617
Committed: http://github.com/Juniper/contrail-controller/commit/e31343d5f0e3c6d8709b3627b5f5ad404f454fb9
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit e31343d5f0e3c6d8709b3627b5f5ad404f454fb9
Author: Yuvaraja Mariappan <email address hidden>
Date: Mon Sep 18 11:31:28 2017 -0700

Fixed service-instance delete issue

During the loadbalancer delete, If the instance ip
is removed before the service instance, the evalute of
service instance would call the create_service_instance()
which would do the chown/update for the instance_ip which
may not be there which would cause this error.

Added exception handler to handle this.

Change-Id: I7688b8818f4b68c117ebc024d192fa3f2b4454fb
Closes-bug: #1716881

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/35687
Committed: http://github.com/Juniper/contrail-controller/commit/afcce433a687c92ee874dc3ff21268caf9153095
Submitter: Zuul (<email address hidden>)
Branch: master

commit afcce433a687c92ee874dc3ff21268caf9153095
Author: Yuvaraja Mariappan <email address hidden>
Date: Mon Sep 18 11:49:06 2017 -0700

Fixed wrong http error code for chown and chmod

chmod and chown sends wrong http error code for
NoIdError which got fixed.
Updated the error handlers in the caller

Change-Id: Id4af532318a66ca080561d06c762aa1cad6066f2
Closes-bug: #1716881

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/35701
Committed: http://github.com/Juniper/contrail-controller/commit/2af08a8f54e289526479cba7ab413a7ee838e8c1
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 2af08a8f54e289526479cba7ab413a7ee838e8c1
Author: Yuvaraja Mariappan <email address hidden>
Date: Mon Sep 18 17:45:28 2017 -0700

Fixed service-instance delete issue

During the loadbalancer delete, If the instance ip
is removed before the service instance, the evalute of
service instance would call the create_service_instance()
which would do the chown/update for the instance_ip which
may not be there which would cause this error.

Added exception handler to handle this.

Change-Id: I7688b8818f4b68c117ebc024d192fa3f2b4454fb
Closes-bug: #1716881