pool of FIP is not displayed when FIP is not associated in Floating IPs tab

[Adam Tengler]

Version: 9.1.2 Mitaka

In ;Project > Compute > Access and Security; view in Mitaka dashboard, we found out that on Floating IPs tab, in the Pool column, you can only see name of the pool if there are floating IPs already associated with instances. I believe it is cause by this - https://github.com/openstack/horizon/blob/mitaka-eol/openstack_dashboard/dashboards/project/access_and_security/tabs.py#L121 . The for cycle populating pool_name attribute on IP is inside 'if attached_instance_ids' condition. We expect to see which pool floating IP came from before the association as it was in Liberty. So the pool_name attribute should be defined in for cycle outside this if condition.

[Adam Tengler (atengler)]

PS: I wanted to create review with proposed fix for this bug myself, but I am unable to post review unless there is a target branch in Gerrit. Is there a way to review bug fixes for Mitaka after the EOL date?

[Ivan Kolodyazhny (e0ne)]

@Adam, we don't support Mitaka branch now. Is this bug affects Pike or Queens? If not, this bug should be marked as invalid

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/508777

[Akihiro Motoki (amotoki)]

This issue exists in the master branch too. Floating IP pool should be displayed in the floating IP table.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/508777
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=aec3a33a2231ecdcc023bb534a90d898aad4c3dc
Submitter: Zuul
Branch: master

commit aec3a33a2231ecdcc023bb534a90d898aad4c3dc
Author: Max Yatsenko <email address hidden>
Date: Sun Oct 1 20:14:22 2017 +0300

    Fix displaying pool name for floating ip

    It fixes an issue when pool name is not
    displayed for floating ip in a case when any
    floating ip is not associated with an instance.

    Change-Id: Ic20ec3709fa7c5313f59a16aa32b975eb004f753
    Closes-Bug: #1716431

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/521054

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/521054
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=997d75643313abe834f5c056d16542cbc328f1ff
Submitter: Zuul
Branch: stable/pike

commit 997d75643313abe834f5c056d16542cbc328f1ff
Author: Max Yatsenko <email address hidden>
Date: Sun Oct 1 20:14:22 2017 +0300

    Fix displaying pool name for floating ip

    It fixes an issue when pool name is not
    displayed for floating ip in a case when any
    floating ip is not associated with an instance.

    Change-Id: Ic20ec3709fa7c5313f59a16aa32b975eb004f753
    Closes-Bug: #1716431
    (cherry picked from commit aec3a33a2231ecdcc023bb534a90d898aad4c3dc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.2 release.