smlite: xmpp auth variables are being set to "True" instead of "true"

[Shashikiran H]

Version: 4.0.1
I have xmpp auth variables set in testbed file.
env.xmpp_auth_enable=True
env.xmpp_dns_auth_enable=True

After provisioning, I see that computes have xmpp auth variables set to "True", which is incorrect.

The below is the final requirement of this bug:
1. Control side should have the xmpp variables set as below:
/etc/contrail/contrail-control.conf : xmpp_auth_enable = True
/etc/contrail/contrail-dns.conf: xmpp_dns_auth_enable = True

2. Agent side should have xmpp variables as :
/etc/contrail/contrail-vrouter-agent.conf:
xmpp_dns_auth_enable = true
xmpp_auth_enable = true

3. Tor agent node should also have xmpp auth set:
EX: /etc/contrail/contrail-tor-agent-1.conf
xmpp_dns_auth_enable = true
xmpp_auth_enable = true

No 3 is not set at all presently. No 2 is incorrectly set.

[Abhay Joshi (abhayj)]

Please get XMPP feature owners to have the variables set consistently on both control and compute - Why should it be set to "true" in compute, but "True" on control when testbed has it set as "True"?

Also regarding XMPP setting in TOR agent config file, please have Hari Killi look into it.

[Hari Prasad Killi (haripk)]

Shashi, what is the problem with agent having True. It should work fine.

[Shashikiran H (skiranh)]

With "True", its currently not working. I thought nipa’s comment #3 in 1590822 is still valid. If this is not the case, will work with Harsh to make "True" also work.

[Kumar Harsh (hkumar)]

only this is not getting set :
3. Tor agent node should also have xmpp auth set:
EX: /etc/contrail/contrail-tor-agent-1.conf
xmpp_dns_auth_enable = true
xmpp_auth_enable = true

contrail-vrouter-agent.conf variables work both with true or True since they are taken as bool switch

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36412
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36449
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36412
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36452
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36453
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36454
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/36455
Submitter: Kumar Harsh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36453
Committed: http://github.com/Juniper/contrail-ansible/commit/c3997aedacc450a727991e60f1b4c99352a6ecb3
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit c3997aedacc450a727991e60f1b4c99352a6ecb3
Author: Harsh Kumar <email address hidden>
Date: Thu Oct 12 17:01:52 2017 +0530

Add xmpp authentication parameters to tor agent.

Change-Id: Ic2832f9849b3f61949a6851fbe41f39c49e3cd99
Closes-Bug: #1716396

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36455
Committed: http://github.com/Juniper/contrail-controller/commit/076b09345e91f8b23ab6a88270d0034c72c3043e
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 076b09345e91f8b23ab6a88270d0034c72c3043e
Author: Kumar Harsh <email address hidden>
Date: Wed Oct 11 15:00:03 2017 +0530

Set xmpp auth variales in contrail-tor-agent.conf

Change-Id: I59dc3140eacfdc59a73d3064c15face0b5cf60af
Closes-Bug: #1716396

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36454
Committed: http://github.com/Juniper/contrail-controller/commit/204736c6a37c0bcfe2ce8509c8c73bb668a1899d
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 204736c6a37c0bcfe2ce8509c8c73bb668a1899d
Author: Kumar Harsh <email address hidden>
Date: Wed Oct 11 15:00:03 2017 +0530

Set xmpp auth variales in contrail-tor-agent.conf

Change-Id: I59dc3140eacfdc59a73d3064c15face0b5cf60af
Closes-Bug: #1716396

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36452
Committed: http://github.com/Juniper/contrail-ansible/commit/bdaa6eeda9bc6e76e03258fdfe13773cee3f88d3
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit bdaa6eeda9bc6e76e03258fdfe13773cee3f88d3
Author: Harsh Kumar <email address hidden>
Date: Thu Oct 12 17:01:52 2017 +0530

Add xmpp authentication parameters to tor agent.

Change-Id: Ic2832f9849b3f61949a6851fbe41f39c49e3cd99
Closes-Bug: #1716396

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36412
Committed: http://github.com/Juniper/contrail-controller/commit/6d7fef4b66695a10d5b79c5a5a4f46019de09cc8
Submitter: Zuul (<email address hidden>)
Branch: master

commit 6d7fef4b66695a10d5b79c5a5a4f46019de09cc8
Author: Kumar Harsh <email address hidden>
Date: Wed Oct 11 15:00:03 2017 +0530

Set xmpp auth variales in contrail-tor-agent.conf

Change-Id: I59dc3140eacfdc59a73d3064c15face0b5cf60af
Closes-Bug: #1716396

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/36449
Committed: http://github.com/Juniper/contrail-ansible/commit/07e674f4b0ad7655c35b2ad5ec5d9c4355d7fde5
Submitter: Zuul (<email address hidden>)
Branch: master

commit 07e674f4b0ad7655c35b2ad5ec5d9c4355d7fde5
Author: Harsh Kumar <email address hidden>
Date: Thu Oct 12 17:01:52 2017 +0530

Add xmpp authentication parameters to tor agent.

Change-Id: Ic2832f9849b3f61949a6851fbe41f39c49e3cd99
Closes-Bug: #1716396