Why are we using legacy Ansible syntax in upgrade_tasks?

[Lars Kellogg-Stedman]

Ansible tasks in the ugprade_tasks block of our service mix modern and legacy ansible syntax. Can we just settle on the more modern syntax? That is, instead of:

            - name: Stop and disable nova_api service (pre-upgrade not under htt
              tags: step2
              service: name=openstack-nova-api state=stopped enabled=no

Can we use:

            - name: Stop and disable nova_api service (pre-upgrade not under htt
              tags: step2
              service:
                name: openstack-nova-api
                state: stopped
                enabled: no

Adopting a common syntax means that it's easier to spot errors, and the advantage of the modern syntax is that it's all just YAML so it's trivial to programatically extract information from playbooks.

[Alex Schultz (alex-schultz)]

Can we enforce only one syntax via a linter?