Ocata -> Pike upgrade: compute upgrade fails during Stop and disable ceilometer compute agent: dict object' has no attribute 'rc'

[Marius Cornea]

Description of problem:
Ocata -> Pike upgrade: compute upgrade fails during Stop and disable ceilometer compute agent: dict object' has no attribute 'rc':

TASK [Stop and disable ceilometer compute agent] *******************************
fatal: [192.168.24.13]: FAILED! => {"failed": true, "msg": "The conditional check '(openstack_ceilometer_compute_enabled.rc == 0) and (step|int == 2)' failed. The error was: error while evaluating conditional ((openstack_ceilometer_compute_enabled.rc == 0) and (step|int == 2)): 'dict object' has no attribute 'rc'\n\nThe error appears to have been in '/home/stack/compute-0/tripleo-_hahkO-config/Compute/upgrade_tasks.yaml': line 45, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 2\n- name: Stop and disable ceilometer compute agent\n ^ here\n"}
        to retry, use: --limit @/home/stack/compute-0/tripleo-_hahkO-config/upgrade_steps_playbook.retry

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-7.0.0-0.20170901051303.0rc1.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy Ocata
2. Upgrade to Pike, major upgrade composable steps
3. Upgrade to Pike compute node

Actual results:
Compute node upgrade fails

Expected results:
Compute node upgrade succeeds

Additional info:

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501637
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d109c1d7a7d2f6302c39369de8a601bc0b2f6704
Submitter: Jenkins
Branch: master

commit d109c1d7a7d2f6302c39369de8a601bc0b2f6704
Author: Marius Cornea <email address hidden>
Date: Thu Sep 7 10:56:29 2017 +0200

    Add defaults for ceilometer-agent-compute upgrade tasks

    This change allows the upgrade non controller script, which loops
    throug all steps, to complete by adding default values to be
    evaluated in the steps where the vars are not registered.

    Closes-Bug: 1715574

    Change-Id: Ic056fc556240d1acc9f28a75f63c7628cc64da03

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/502459

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/502459
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=485fc6d65e75d65c400599699dab7624894f2c1d
Submitter: Jenkins
Branch: stable/pike

commit 485fc6d65e75d65c400599699dab7624894f2c1d
Author: Marius Cornea <email address hidden>
Date: Thu Sep 7 10:56:29 2017 +0200

    Add defaults for ceilometer-agent-compute upgrade tasks

    This change allows the upgrade non controller script, which loops
    throug all steps, to complete by adding default values to be
    evaluated in the steps where the vars are not registered.

    Closes-Bug: 1715574

    Change-Id: Ic056fc556240d1acc9f28a75f63c7628cc64da03
    (cherry picked from commit d109c1d7a7d2f6302c39369de8a601bc0b2f6704)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.