incorrect call to leader_set

[James Page]

noted during amulet testing of the designate-bind charm:

2017-09-07 03:35:53 WARNING juju-log identity-service:8: Checking API service is responding
2017-09-07 03:36:06 DEBUG identity-service-relation-changed 78aa5122-e2b9-4bbb-ad6d-7b3db1bf2a7f
2017-09-07 03:36:07 DEBUG identity-service-relation-changed Traceback (most recent call last):
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/charm/hooks/identity-service-relation-changed", line 19, in <module>
2017-09-07 03:36:07 DEBUG identity-service-relation-changed main()
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.5/site-packages/charms/reactive/__init__.py", line 78, in main
2017-09-07 03:36:07 DEBUG identity-service-relation-changed bus.dispatch()
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.5/site-packages/charms/reactive/bus.py", line 423, in dispatch
2017-09-07 03:36:07 DEBUG identity-service-relation-changed _invoke(other_handlers)
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.5/site-packages/charms/reactive/bus.py", line 406, in _invoke
2017-09-07 03:36:07 DEBUG identity-service-relation-changed handler.invoke()
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.5/site-packages/charms/reactive/bus.py", line 280, in invoke
2017-09-07 03:36:07 DEBUG identity-service-relation-changed self._action(*args)
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/charm/reactive/designate_handlers.py", line 162, in configure_designate_full
2017-09-07 03:36:07 DEBUG identity-service-relation-changed instance.create_initial_servers_and_domains()
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "lib/charm/openstack/designate.py", line 486, in create_initial_servers_and_domains
2017-09-07 03:36:07 DEBUG identity-service-relation-changed hookenv.leader_set(KEY, 'done')
2017-09-07 03:36:07 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.5/site-packages/charmhelpers/core/hookenv.py", line 898, in inner_translate_exc2
2017-09-07 03:36:07 DEBUG identity-service-relation-changed return f(*args, **kwargs)
2017-09-07 03:36:07 DEBUG identity-service-relation-changed TypeError: leader_set() takes from 0 to 1 positional arguments but 2 were given

should be:

hookenv.leader_set({KEY: 'done'})

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501599
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=8b852fc94ae80304333f93bda5482004e5625847
Submitter: Jenkins
Branch: master

commit 8b852fc94ae80304333f93bda5482004e5625847
Author: James Page <email address hidden>
Date: Thu Sep 7 08:20:19 2017 +0100

    Correct leader_set call

    Fix the call to leader_set in create_initial_servers_and_domains
    to pass a dict of data, rather than incorrectly just passing two
    values.

    Change-Id: Ic12808e1e7f76dfd013cd6ab51f5edccbb73f325
    Closes-Bug: 1715567