Listing resources with 'fields' and 'limit' doesn't return a 'next' link correctly

[Hironori Shiina]

If API to list resources is requested with the 'fields' parameter and the 'limit' parameter, the 'next' parameter doesn't give an appropriate URL. The 'fields' parameter is not added in the URL. If 'uuid' field is not specified in 'fields' request parameter, the 'maker' request parameter in the 'next' URL is set to 'Unset'.

When the following request is posted:
  GET /v1/volume/connectors/?limit=1&fields=type,connector_id
It got a response with the following 'next' parameter:
  "next": "http://127.0.0.1:6385/v1/volume/connectors?sort_key=id&sort_dir=asc&limit=1&marker=Unset"

[Vasyl Saienko (vsaienko)]

can't reproduce. my output is http://paste.openstack.org/show/621638/

[Vasyl Saienko (vsaienko)]

the fields indeed missing in the next link

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/506280

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/508368

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/505837
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=f8a42d366c0d20918fee579406feffe83c1f7b9a
Submitter: Jenkins
Branch: master

commit f8a42d366c0d20918fee579406feffe83c1f7b9a
Author: Ruby Loo <email address hidden>
Date: Wed Sep 20 18:19:17 2017 -0400

    ListType preserves the order of the input

    The ListType class returns a list of items in a string.
    The list was not guaranteed to be the same order as in the string;
    this patch changes it so that the order is preserved.

    Related-Bug: #1715541
    Change-Id: Iefab751d34e97f460b6d63316eb38085e4eb1154

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dmitry Tantsur <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/506280
Reason: Abandoning because of inactivity. Will need to be significantly reworked to match the new API architecture.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Dmitry Tantsur <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/508368
Reason: Abandoning because of inactivity. Will need to be significantly reworked to match the new API architecture.

[Iury Gregory Melo Ferreira (iurygregory)]

Marking as Invalid since the change was abandoned. Feel free to re-open if necessary.

[Iury Gregory Melo Ferreira (iurygregory)]

Moving to Incomplete, I don't have a setup at the moment to reproduce, but I will try to test if we can still reproduce this issue.

[Dmitry Tantsur (divius)]

Tested on Bifrost, I cannot confirm this bug any more:

$ curl -sH "x-openstack-ironic-api-version: 1.80" -u "..." "http://192.168.122.1:6385/v1/nodes?fields=name&limit=1" | jq .
{
  "nodes": [
    {
      "name": "testvm1",
      "links": [
        {
          "href": "http://192.168.122.1:6385/v1/nodes/4e41df61-84b1-5856-bfb6-6b5f2cd3dd11",
          "rel": "self"
        },
        {
          "href": "http://192.168.122.1:6385/nodes/4e41df61-84b1-5856-bfb6-6b5f2cd3dd11",
          "rel": "bookmark"
        }
      ]
    }
  ],
  "next": "http://192.168.122.1:6385/v1/nodes?sort_key=id&sort_dir=asc&fields=name&limit=1&marker=4e41df61-84b1-5856-bfb6-6b5f2cd3dd11"
}

All links look correct to me.