After undercloud update, overcloud updates fail with The Workflow (tripleo.overcloud.workflowtasks.step2) could not be found.

[Giulio Fidente]

We seem to be removing all workflows with 'tripleo' in the name from instack-undercloud after the undercloud update [1]

Some of the workflows (tripleo.$stackname.workflowtasks.$stepnumber) are created during the stack deployment [2] are necessary on stack updates and should not be removed.

1. https://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L1533
2. https://github.com/openstack/tripleo-heat-templates/blob/master/common/deploy-steps.j2#L109

[Alex Schultz (alex-schultz)]

Can we rename the dynamically created tasks to a different format perhaps?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/501319

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/501326

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501319
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e0434359dd291d283b8c5c6246aeb48171995dbf
Submitter: Jenkins
Branch: master

commit e0434359dd291d283b8c5c6246aeb48171995dbf
Author: Dougal Matthews <email address hidden>
Date: Wed Sep 6 16:46:11 2017 +0100

    Add "tripleo-common-managed" to all workflows in tripleo_common

    At the moment instack-undercloud deletes all workflows with "tripleo" in
    the name. This has caused an issue when workflows come from other
    locations but shouldn't be deleted.

    Adding the tag allows instack-undercloud to delete only workflows with
    this tag. It shouldn't delete or touch workflows outside of the
    tripleo-common package.

    Parital-Bug: #1715389
    Change-Id: Ieeb51f8e705b8988fb4d0f5d17d7fce6b5b04f36

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501554

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/501594

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501554
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=87ec6cf5a98069d4ea5f979bb9d4af4545926e49
Submitter: Jenkins
Branch: stable/pike

commit 87ec6cf5a98069d4ea5f979bb9d4af4545926e49
Author: Dougal Matthews <email address hidden>
Date: Wed Sep 6 16:46:11 2017 +0100

    Add "tripleo-common-managed" to all workflows in tripleo_common

    At the moment instack-undercloud deletes all workflows with "tripleo" in
    the name. This has caused an issue when workflows come from other
    locations but shouldn't be deleted.

    Adding the tag allows instack-undercloud to delete only workflows with
    this tag. It shouldn't delete or touch workflows outside of the
    tripleo-common package.

    Parital-Bug: #1715389
    Change-Id: Ieeb51f8e705b8988fb4d0f5d17d7fce6b5b04f36
    (cherry picked from commit e0434359dd291d283b8c5c6246aeb48171995dbf)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501326
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=d6c0636421d2186690a4f0d46533593f4ad8ad19
Submitter: Jenkins
Branch: master

commit d6c0636421d2186690a4f0d46533593f4ad8ad19
Author: Dougal Matthews <email address hidden>
Date: Wed Sep 6 16:56:09 2017 +0100

    Only delete workflows with the tripleo-common-managed tag

    The new workflow tag allows us to detect tripleo-common workflows. It is
    safe to delete and reload these. Workflows that come from other places
    shouldn't be removed.

    There is some upgrade logic here that handles the O -> P upgrade, as on
    the first run the workflows will not have the tripleo-common-managed
    tag. If the tag isn't found, we revert to the current behaviour and then
    on future undercloud installations this wont be a problem.

    The new test is a duplication of a previous test but with multiple
    workflows that have tripleo in the name. Only the one with the tag is
    deleted.

    Depends-On: Ieeb51f8e705b8988fb4d0f5d17d7fce6b5b04f36
    Closes-Bug: #1715389
    Change-Id: I84d441daedcafe686b9576d47b037977b493dbc7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501844
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=72ce841253cf513ccc1f081efdddf76eb6bdf7c0
Submitter: Jenkins
Branch: stable/pike

commit 72ce841253cf513ccc1f081efdddf76eb6bdf7c0
Author: Dougal Matthews <email address hidden>
Date: Wed Sep 6 16:56:09 2017 +0100

    Only delete workflows with the tripleo-common-managed tag

    The new workflow tag allows us to detect tripleo-common workflows. It is
    safe to delete and reload these. Workflows that come from other places
    shouldn't be removed.

    There is some upgrade logic here that handles the O -> P upgrade, as on
    the first run the workflows will not have the tripleo-common-managed
    tag. If the tag isn't found, we revert to the current behaviour and then
    on future undercloud installations this wont be a problem.

    The new test is a duplication of a previous test but with multiple
    workflows that have tripleo in the name. Only the one with the tag is
    deleted.

    Depends-On: Ieeb51f8e705b8988fb4d0f5d17d7fce6b5b04f36
    Closes-Bug: #1715389
    Change-Id: I84d441daedcafe686b9576d47b037977b493dbc7
    (cherry picked from commit d6c0636421d2186690a4f0d46533593f4ad8ad19)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.4.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501594
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a7a02f0da866c66dce9757a42bf56144cfa70d5a
Submitter: Jenkins
Branch: master

commit a7a02f0da866c66dce9757a42bf56144cfa70d5a
Author: Giulio Fidente <email address hidden>
Date: Thu Sep 7 09:13:04 2017 +0200

    Tag workflows created by the templates

    This is useful to easily filter workflows created by the templates
    and for a specific stack.

    Change-Id: I0a26cacaf5ad5709881043434694c9254a9e710b
    Related-Bug: #1715389

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/503762

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/503766

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/503766
Reason: https://review.openstack.org/#/c/503762/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503762
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f890e4e5120e7e969a1d0c9ca10a798ddb626eef
Submitter: Zuul
Branch: master

commit f890e4e5120e7e969a1d0c9ca10a798ddb626eef
Author: Giulio Fidente <email address hidden>
Date: Wed Sep 13 19:34:14 2017 +0200

    Revert "Revert "Tag workflows created by the templates""

    Also touches ceph-ansible/ceph-base.yaml to make sure this is
    tested by scenario001

    Change-Id: I7a7beea36669a79662f384315a3fbd19c958de8a
    Related-Bug: #1715389

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/520357

[OpenStack Infra (hudson-openstack)]

Change abandoned by Giulio Fidente (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/520357
Reason: Never landed into master