Cannot launch instance with Django Launch Instance form with multiple networks for a tenant

[Akihiro Motoki]

When LAUNCH_INSTANCE_LEGACY_ENABLED is set to True and the Django launch instance form is used, a user cannot launch an instance when there is multiple networks. I selected network(s) and submitted the form, but the launch instance workflow was shown again. The selected networks are reset and all networks are shown in the Available Networks. As a result, users cannot launch instances with the Django Launch Instance form.

It seems something has changed in Django 1.11.

Previously network ID is shown with a small gray characters but now "(undefined)" is shown, so it looks like generate_html() JS function does not work expectedly.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/506190

[Ivan Kolodyazhny (e0ne)]

Verified that it's not reproducible with django==1.10

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/507560

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/507560
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c13d6da80e7a68c28aa0adfe63459be8a6dbedfd
Submitter: Jenkins
Branch: master

commit c13d6da80e7a68c28aa0adfe63459be8a6dbedfd
Author: Ivan Kolodyazhny <email address hidden>
Date: Tue Sep 26 17:26:45 2017 +0300

    Add render method to ThemableCheckboxSelectMultiple

    Django 1.11+ doesn't have RenderMixin class for widgets, so we have to
    implement render method for ThemableCheckboxSelectMultiple to get it
    rendered in a correct way with all supported Django versions until we
    find a better solution for our widgets implementation.

    Change-Id: I656afb162e130f2b77853368945b74330bedf747
    Closes-Bug: #1715066

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/534355

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/534355
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2ab0ea8c6a6eb8f1d6d6e04959426487c558c4a9
Submitter: Zuul
Branch: stable/pike

commit 2ab0ea8c6a6eb8f1d6d6e04959426487c558c4a9
Author: Ivan Kolodyazhny <email address hidden>
Date: Tue Sep 26 17:26:45 2017 +0300

    Add render method to ThemableCheckboxSelectMultiple

    Django 1.11+ doesn't have RenderMixin class for widgets, so we have to
    implement render method for ThemableCheckboxSelectMultiple to get it
    rendered in a correct way with all supported Django versions until we
    find a better solution for our widgets implementation.

    Change-Id: I656afb162e130f2b77853368945b74330bedf747
    Closes-Bug: #1715066
    (cherry picked from commit c13d6da80e7a68c28aa0adfe63459be8a6dbedfd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.3 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/506190
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.