GET /resource_providers: "links" doesn't include "allocations"

Bug #1714275 reported by Eric Fried
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Eric Fried

Bug Description

GET /resource_providers returns:
{
  "resource_providers": [
    {
      "generation": 39,
      "uuid": "213fd7f8-1e9f-466b-87bf-0902b0b3bc13",
      "links": [
        {
          "href": "/placement/resource_providers/213fd7f8-1e9f-466b-87bf-0902b0b3bc13",
          "rel": "self"
        },
        {
          "href": "/placement/resource_providers/213fd7f8-1e9f-466b-87bf-0902b0b3bc13/inventories",
          "rel": "inventories"
        },
        {
          "href": "/placement/resource_providers/213fd7f8-1e9f-466b-87bf-0902b0b3bc13/usages",
          "rel": "usages"
        },
        {
          "href": "/placement/resource_providers/213fd7f8-1e9f-466b-87bf-0902b0b3bc13/aggregates",
          "rel": "aggregates"
        },
        {
          "href": "/placement/resource_providers/213fd7f8-1e9f-466b-87bf-0902b0b3bc13/traits",
          "rel": "traits"
        }
      ],
      "name": "p8-100-neo"
    }
  ]
}

The link for "/resource_providers/213fd7f8-1e9f-466b-87bf-0902b0b3bc13/allocations" is missing.

For reference: https://review.openstack.org/#/c/366789/ added the /resource_providers/<uuid>/allocations target; and https://review.openstack.org/#/c/468923/ did the per-microversion splitup of which links were reported. They were dropped in that order, by the same author (cdent), so maybe there's a reason for this...

Placement microversion 1.10

Devstack on PowerVM

Nova master branch at commit 4579d2e5573ae1bbabb51ee46ef26598d9410b15 (Aug 11)

Tags: api placement
Matt Riedemann (mriedem)
tags: added: api placement
Revision history for this message
Chris Dent (cdent) wrote :

Yeah, I would guess this was an oversight. I think we added the allocations URI on /resource_providers/{uuid}/allocations in a rush at the end of one of the cycles (it's all blurring together now).

Good catch.

Changed in nova:
assignee: nobody → Eric Fried (efried)
status: New → In Progress
Revision history for this message
Eric Fried (efried) wrote :

D'oh, /me forgot to include Closes-Bug on PS1.

https://review.openstack.org/#/c/499826/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/499826
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a9105b4904b23f640537b36b6b474e74dab26541
Submitter: Zuul
Branch: master

commit a9105b4904b23f640537b36b6b474e74dab26541
Author: Eric Fried <email address hidden>
Date: Thu Aug 31 17:02:33 2017 -0500

    Include /resource_providers/uuid/allocations link

    /resource_providers/{rp_uuid}/allocations has been available since
    microversion 1.0 [1], but wasn't listed in the "links" section of the
    GET /resource_providers response. This change adds the link in a new
    microversion, 1.11

    [1] https://review.openstack.org/#/c/366789/

    Closes-Bug: #1714275

    Change-Id: I6a1d320ce914926791d5f45e89bf4c601a6b10a0

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.0.0b2

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.