Maintain Control Numbers function should be schema-qualified

[Chris Sharp]

Currently, the maintain_control_numbers function is not schema-qualified, which makes it land in the public schema by default. For upgraded installations where there may be an evergreen.maintain_control_numbers function, this results in a situation where the older wrong function is in the search_path before the correct one (default search_path is "$user", public).

Branch on the way.

Evergreen 2.12.4
OpenSRF 2.5.0
Postgresql 9.4
Ubuntu 14.04 LTS

[Chris Sharp (chrissharp123)]

And here's the branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1714026_schema_qualify_maintain_control_numbers

[Bob Wicksall (bwicksall)]

I ran into this upgrading from 2.10.4 to 3.0 beta1. In the middle of 2.12.5-3.0-beta1-upgrade-db.sql I was getting the following error:

psql:version-upgrade/2.12.5-3.0-beta1-upgrade-db.sql:2537: ERROR: Cannot decode string with wide characters at /usr/lib/x86_64-linux-gnu/perl/5.20/Encode.pm line 217.
CONTEXT: PL/Perl function "maintain_control_numbers"
psql:version-upgrade/2.12.5-3.0-beta1-upgrade-db.sql:2539: ERROR: current transaction is aborted, commands ignored until end of transaction block

I applied Chris Sharp's patch. I still have bad data but I'm getting more meaningful errors and warnings.

I also confirmed that the duplicate maintain_control_numbers function exists in our 2.10 instance.

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.0-rc. Thanks, Chris!